Open
Conversation
Fixes handling ZWNBSP characters at the start of a file - Seems to be very common in XML files
This was referenced Jan 18, 2025
Contributor
|
Thanks for highlighting this issue! I think a little more work needed to properly handle byte order marks. Skipping the first line if the file starts with a BOM isn't necessarily correct: it works for file types covered by the Please add a unit test which covers at least
Since Go strings are UTF-8, these tests will need to use byte arrays directly, with big-endian and little-endian versions of the BOM sequence. |
Contributor
|
Friendly ping @JackStuart regarding the comments above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes handling ZWNBSP characters at the start of a file - Seems to be very common in XML files
Renamed File2 to File1 due to there being no File1.xml - So there was no point skipping to File2
Fixed typo of declaratioon
Resolves the issue here - mandiant/flare-vm#640