fix: rearrange events sort causing message disorder

[yuhao101]

This PR addresses an issue identified in the adk-java v0.4.0 release version. #632

[gemini-code-assist]

Summary of Changes

Hello @yuhao101, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This change focuses on improving the stability and correctness of conversation history management within the adk-java project. By refining how function response events are processed and rearranged, the pull request ensures that messages maintain their intended order, preventing a previously identified issue of message disorder caused by duplicate event entries. The core impact is a more reliable and accurate representation of conversational flow.

Highlights

• Addressing Message Disorder: This pull request resolves an issue where the order of messages could become disordered due to duplicate function response events being incorrectly added to the conversation history.
• Refined Event Rearrangement Logic: The rearrangeEventsForAsyncFunctionResponsesInHistory method has been updated to explicitly exclude events containing function response parts if they are encountered outside the specific function call handling logic, preventing redundant additions.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses a bug causing message disorder by preventing duplicate function response events in the event history. The fix correctly identifies and skips these events when they are not associated with a function call. My review includes a suggestion to simplify the implementation for better readability and conciseness.

[yuhao101]

Hi maintainers, this PR is ready for review. Could someone help approve the workflow? Thanks!

[r4inee]

👋 @yuhao101

I ran into a similar problem when using long running tools - have made a slightly different fix here #682 which seems to also address your case.