Skip to content

fix(evals): skip invocations without user events#5997

Open
ynachiket wants to merge 1 commit into
google:mainfrom
ynachiket:ynachiket/skip-eval-invocations-without-user-3760
Open

fix(evals): skip invocations without user events#5997
ynachiket wants to merge 1 commit into
google:mainfrom
ynachiket:ynachiket/skip-eval-invocations-without-user-3760

Conversation

@ynachiket
Copy link
Copy Markdown

Summary

  • Skip grouped eval invocations that never include a user-authored event.
  • Keep normal user/agent invocation conversion unchanged.
  • Add regression coverage for sessions containing an agent-only invocation followed by a valid user turn.

Fixes #3760.

Validation

  • /tmp/adk-pdlc051-venv/bin/python -m pytest tests/unittests/evaluation/test_evaluation_generator.py -q (19 passed, 4 warnings)
  • /tmp/adk-pdlc051-venv/bin/python -m py_compile src/google/adk/evaluation/evaluation_generator.py tests/unittests/evaluation/test_evaluation_generator.py
  • git diff --check

@google-cla
Copy link
Copy Markdown

google-cla Bot commented Jun 6, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@adk-bot adk-bot added the eval [Component] This issue is related to evaluation label Jun 6, 2026
@adk-bot
Copy link
Copy Markdown
Collaborator

adk-bot commented Jun 6, 2026

Response from ADK Triaging Agent

Hello @ynachiket, thank you for your pull request!

We noticed a few things to align with our contribution guidelines:

  • Contributor License Agreement (CLA): It seems the Google CLA check has failed. Please make sure to sign the Contributor License Agreement at https://cla.developers.google.com/ to proceed.
  • Testing Plan & Logs: While you provided a "Validation" section with test execution commands, please ensure you include an explicit testing plan section and provide logs or output demonstrating how the fix behaves after being applied.

These steps will help the reviewers better understand and review your changes efficiently. Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

eval [Component] This issue is related to evaluation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Evaluation Invocation.user_content ValidationError when session has invocations without user events

2 participants