Skip to content

fix(tests): isolate mock session payloads in Vertex AI session service tests #7158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jinzhengxu wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −5
Open

fix(tests): isolate mock session payloads in Vertex AI session service tests #7158

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions tests/unittests/sessions/test_vertex_ai_session_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -620,12 +620,16 @@ def mock_vertex_ai_session_service(
def mock_api_client_instance():
"""Creates a mock API client instance for testing."""
api_client = MockAsyncClient()
# Deep-copy the session payloads like the events below: the mock client
# mutates `session_dict[...]['update_time']` when an event is appended, and
# sharing the module-level dicts across tests would leak that update into
# later tests that compare against `MOCK_SESSION`.
api_client.session_dict = {
'1': MOCK_SESSION_JSON_1,
'2': MOCK_SESSION_JSON_2,
'3': MOCK_SESSION_JSON_3,
'page1': MOCK_SESSION_JSON_PAGE1,
'page2': MOCK_SESSION_JSON_PAGE2,
'1': copy.deepcopy(MOCK_SESSION_JSON_1),
'2': copy.deepcopy(MOCK_SESSION_JSON_2),
'3': copy.deepcopy(MOCK_SESSION_JSON_3),
'page1': copy.deepcopy(MOCK_SESSION_JSON_PAGE1),
'page2': copy.deepcopy(MOCK_SESSION_JSON_PAGE2),
}
api_client.event_dict = {
'1': (copy.deepcopy(MOCK_EVENT_JSON), None),
Expand Down