Conversation
2 tasks
barbibulle
reviewed
Oct 4, 2023
| ) | ||
|
|
||
| def on_read_only_properties_read(connection: Connection) -> bytes: | ||
| value = ( |
Collaborator
There was a problem hiding this comment.
is this value expected to change during the lifetime of the characteristic? If not, why not construct it just once at init time?
| + bytes(AshaService.RESERVED_FOR_FUTURE_USE) | ||
| + bytes(AshaService.SUPPORTED_CODEC_ID) | ||
| ) | ||
| self.emit("read_only_properties", connection, value) |
Collaborator
There was a problem hiding this comment.
The event name is not typical. Event names are normally nouns. The even here is that there is a read request on the characteristic. The event name should probably, then, just be 'read'.
But more important question: is this only for testing? Maybe the Attribute class itself should emit a 'read' event (like it emits a 'write' event), to make this observability more generally available?
| return value | ||
|
|
||
| def on_le_psm_out_read(connection: Connection) -> bytes: | ||
| self.emit("le_psm_out", connection, self.psm) |
Collaborator
There was a problem hiding this comment.
same comment about event names as above.
Collaborator
|
closing as obsolete |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.