add basic support for SCI #871
Conversation
bumble/hci.py
Outdated
| frame_space_min: int = field(metadata=metadata(2)) | ||
| frame_space_max: int = field(metadata=metadata(2)) | ||
| phys: int = field(metadata=PhyBit.type_metadata(1)) | ||
| spacing_types: int = field(metadata=SpacingType.type_metadata(1)) |
There was a problem hiding this comment.
Should be SpacingType.type_metadata(2)?
| ) | ||
|
|
||
| if self.cis_enabled: | ||
| if self.cis_enabled and self.host.supports_command( |
There was a problem hiding this comment.
I am thinking if we should have some warning if some configs cannot be fulfilled due to the lack of support in controller, but it will make the flow control a bit too long-winded here.
There was a problem hiding this comment.
Good idea. We'd have to think about how to make this non-intrusive. For now, the device config can specify a number of enabled flags, but that doesn't necessarily mean they're required. An app could enable a number of features, but still work if those are not present. We wouldn't want to warn in that case.
What may make sense is to have some checker function that allows the caller to check compatibiliyt/availability of certain features (like we do for example in auracast to check if perdiodic advertising is supported when attempting a scan command.
2 participants
This allows setting shorter connection intervals with controllers that support the feature (introduced in spec version 6.2)