Expose remaining cgroup v2 memory.events counters (oom, oom_kill, oom_group_kill, low)#3889
Open
note89 wants to merge 3 commits into
Open
Expose remaining cgroup v2 memory.events counters (oom, oom_kill, oom_group_kill, low)#3889note89 wants to merge 3 commits into
note89 wants to merge 3 commits into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Surface the low counter from memory.events alongside the OOM counters, as container_memory_events_low_total. Requested in PR feedback.
note89
changed the title
Author
|
@egorikas I saw your comment, added low, tnx! |
Contributor
Oops, I've somehow deleted it :) Thanks for adding a metric per my request :) |
Align metric descriptions with kernel cgroup v2 semantics: - low counts reclaim despite usage being under the memory.low boundary, so "reclaim events" instead of "breach events". - oom counts entering the OOM state, not page allocation faults; the previous wording was nearly identical to the existing container_memory_failures_total help text.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Follow-up to #3870. Expose the remaining cgroup v2
memory.eventscounters as Prometheus metrics:container_memory_events_oom_totalcontainer_memory_events_oom_kill_totalcontainer_memory_events_oom_group_kill_totalcontainer_memory_events_low_total(added on request from @egorikas)With these, all six
memory.eventscounters (low,high,max,oom,oom_kill,oom_group_kill) are exposed.Why:
memory.eventsalready contains these counters on cgroup v2 systems. Exposing them gives operators direct cgroup-level visibility into allocation failures, OOM kills, and memory.low protection breaches. This is separate from the existingcontainer_oom_events_totalmetric, which comes from the OOM event path rather than the cgroup v2memory.eventscounters.How:
low,oom,oom_kill, andoom_group_killin the existingsetMemoryEventspath.info/v1.MemoryEventsand emit them under the existing memory metric set.