Skip to content

docker: collect fs stats for overlayfs storage driver#3892

Open
bmgeek wants to merge 1 commit into
google:masterfrom
bmgeek:fix-docker-overlayfs-fs-stats
Open

docker: collect fs stats for overlayfs storage driver#3892
bmgeek wants to merge 1 commit into
google:masterfrom
bmgeek:fix-docker-overlayfs-fs-stats

Conversation

@bmgeek

@bmgeek bmgeek commented Jun 15, 2026

Copy link
Copy Markdown

What

Include ContainerdSnapshotterStorageDriver in Docker FsStats() disk usage handling.

Why

#3709 added Docker containerd snapshotter support for the overlayfs storage driver by loading the container rootfs path from the containerd spec.

However, container/docker/fs.go still falls through the default branch for ContainerdSnapshotterStorageDriver, so stats.Filesystem is not populated. As a result, per-container container_fs_* metrics are missing even though the Docker container itself is discovered correctly.

Testing

Manually verified on Docker 29.5+ with storage driver overlayfs:

  • before: container_fs_usage_bytes{name!=""} was not emitted
  • after: container_fs_usage_bytes, container_fs_limit_bytes, and inode metrics are emitted for Docker containers

Related to #3709 and #3860.

@google-cla

google-cla Bot commented Jun 15, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@bmgeek bmgeek force-pushed the fix-docker-overlayfs-fs-stats branch from 568d54c to a324f03 Compare June 15, 2026 14:00
Signed-off-by: Aleksandr Krupin <67244556+bmgeek@users.noreply.github.com>
@bmgeek bmgeek force-pushed the fix-docker-overlayfs-fs-stats branch from a324f03 to e0456b7 Compare June 15, 2026 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant