Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
It's not, changed the email to the one you have on file for the CLA. |
|
/gcbrun |
|
@alexsnaps could you update testdata/standard_env.prompt.txt and remove line 222: cel-go/cel/testdata/standard_env.prompt.txt Line 222 in 6b8f6d6 |
The conversion isn't implemented, but mostly isn't part of the language specification. The behavior remains mostly unchanged, the resulting error changes tho, still an error: - pre: type conversion error from 'int' to 'google.protobuf.Duration' - post: found no matching overload for 'duration' applied to '(int)' Signed-off-by: Alex Snaps <alex@wcgw.dev>
|
Fixed |
|
/gcbrun |
|
If I get this failure right, it complains about the line being gone now? Is that right? I really have no where the "authority" for that is sourced from... I have no experience with this test suite tbh |
The conversion isn't implemented, but mostly isn't part of the language specification. The behavior remains mostly unchanged, the resulting error changes tho, still an error:
The error would now be caught by the checker, instead of the evaluation time one previously.