Skip to content

fix: deleted IntToDuration overload#1300

Open
alexsnaps wants to merge 1 commit intogoogle:masterfrom
alexsnaps:issue-1299
Open

fix: deleted IntToDuration overload#1300
alexsnaps wants to merge 1 commit intogoogle:masterfrom
alexsnaps:issue-1299

Conversation

@alexsnaps
Copy link
Copy Markdown

@alexsnaps alexsnaps commented Apr 6, 2026

The conversion isn't implemented, but mostly isn't part of the language specification. The behavior remains mostly unchanged, the resulting error changes tho, still an error:

  • pre: type conversion error from 'int' to 'google.protobuf.Duration'
  • post: found no matching overload for 'duration' applied to '(int)'

The error would now be caught by the checker, instead of the evaluation time one previously.

@google-cla
Copy link
Copy Markdown

google-cla bot commented Apr 6, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@alexsnaps
Copy link
Copy Markdown
Author

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project.

It's not, changed the email to the one you have on file for the CLA.

@TristonianJones
Copy link
Copy Markdown
Collaborator

/gcbrun

TristonianJones
TristonianJones previously approved these changes Apr 8, 2026
@TristonianJones
Copy link
Copy Markdown
Collaborator

@alexsnaps could you update testdata/standard_env.prompt.txt and remove line 222:

duration(int) -> google.protobuf.Duration

The conversion isn't implemented, but mostly isn't part of the language
specification. The behavior remains mostly unchanged, the resulting
error changes tho, still an error:

 - pre: type conversion error from 'int' to 'google.protobuf.Duration'
 - post: found no matching overload for 'duration' applied to '(int)'

Signed-off-by: Alex Snaps <alex@wcgw.dev>
@alexsnaps
Copy link
Copy Markdown
Author

Fixed

@TristonianJones
Copy link
Copy Markdown
Collaborator

/gcbrun

@alexsnaps
Copy link
Copy Markdown
Author

If I get this failure right, it complains about the line being gone now?

 - 	      duration(int) -> google.protobuf.Duration

Is that right? I really have no where the "authority" for that is sourced from... I have no experience with this test suite tbh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants