[internal/LibFuzzer] Add option to set cwd to BUILD_DIR based on environment#5260
Open
notvictorl wants to merge 3 commits intogoogle:masterfrom
Open
[internal/LibFuzzer] Add option to set cwd to BUILD_DIR based on environment#5260notvictorl wants to merge 3 commits intogoogle:masterfrom
notvictorl wants to merge 3 commits intogoogle:masterfrom
Conversation
notvictorl
changed the title
…ronment Add optional cwd argument to LibFuzzerRunner class which passes to parent ProcessRunner class to subprocess.Popen with cwd argument. When a LibFuzzerRunner is requested with get_runner() the cwd can be set to BUILD_DIR using FUZZ_TARGET_CWD_IS_BUILD_DIR boolean env var.
dylanjew
reviewed
Apr 29, 2026
Collaborator
dylanjew
left a comment
dylanjew
left a comment
There was a problem hiding this comment.
overall looks good! Added a couple questions.
Could you also add some context to the description about why this is needed and/or attach a bug?
Collaborator
|
/gcbrun |
Collaborator
Author
|
/gcbrun |
1 similar comment
Collaborator
|
/gcbrun |
dylanjew
approved these changes
Apr 29, 2026
Collaborator
dylanjew
left a comment
dylanjew
left a comment
There was a problem hiding this comment.
Thanks for updating the description!
Collaborator
Author
|
/gcbrun |
Collaborator
Author
|
@ViniciustCosta friendly nudge to review |
ViniciustCosta
approved these changes
May 5, 2026
Collaborator
ViniciustCosta
left a comment
ViniciustCosta
left a comment
There was a problem hiding this comment.
IIUC, this will not change the behavior of jobs that do not contain that FUZZ_TARGET_CWD_IS_BUILD_DIR env var. So, lgtm to be merged
Please, notice that since we did not test it, when you set that for a job, you should monitor it closely to guarantee that all tasks are still executing properly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libfuzzer_chrome_msanbots have errors caused by thecwdbeing wrong when we execute the fuzzer. We are looking to passBUILD_DIRtocwdso that fuzzers are executed from the archive root.Bug: https://crbug.com/507025973, https://crbug.com/326101784#comment46
cwdargument toLibFuzzerRunnerclass which passes to parentProcessRunnerclass which will runsubprocess.Popenwith thecwdargument.LibFuzzerRunneris requested withget_runner()thecwdis set toBUILD_DIRifFUZZ_TARGET_CWD_IS_BUILD_DIRis true