Add RISC-V target detection#75
Open
carlosqwqqwq wants to merge 1 commit into
Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
crc32c did not expose a dedicated RISC-V target in its CMake architecture selection, so riscv configurations could still flow through x86 or ARM feature probes indirectly. This patch makes the baseline RISC-V path explicit while keeping the portable implementation path.
What changed
CMAKE_SYSTEM_PROCESSOR,CMAKE_HOST_SYSTEM_PROCESSOR, andCMAKE_CXX_COMPILER_TARGET.CRC32C_TARGET_RISCVfor RISC-V configurations._mm_prefetchand SSE4.2 intrinsics for x86 targets.getauxvalsupport for ARM64 targets.Verification
cmake --build build-codex-native --parallel 4.ctest --test-dir build-codex-native --output-on-failure;crc32c_testsandcrc32c_capi_testsboth passed.crc32c_config.h:HAVE_MM_PREFETCH=1,HAVE_SSE42=1, andCRC32C_TARGET_RISCV=0.riscv64CMake configuration withCMAKE_SYSTEM_NAME=Linux,CMAKE_SYSTEM_PROCESSOR=riscv64, andCMAKE_TRY_COMPILE_TARGET_TYPE=STATIC_LIBRARY.riscv64static library successfully withcmake --build build-codex-riscv --target crc32c --parallel 4.crc32c_config.h:CRC32C_TARGET_RISCV=1,HAVE_MM_PREFETCH=0,HAVE_SSE42=0,HAVE_ARM64_CRC32C=0,HAVE_STRONG_GETAUXVAL=0, andHAVE_WEAK_GETAUXVAL=0.build-codex-riscv/compile_commands.json: no-msse4.2,/arch:AVX, or-march=armv8-a+crc+cryptoflags were present.Notes
This is a conservative portability patch. It does not add RISC-V hardware CRC instructions or RVV acceleration. No real riscv64 cross-toolchain or hardware validation was available on the local Windows host.