Allow templates on crubit_internal_rust_type#522
Open
copybara-service[bot] wants to merge 1 commit intomainfrom
Open
Allow templates on crubit_internal_rust_type#522copybara-service[bot] wants to merge 1 commit intomainfrom
copybara-service[bot] wants to merge 1 commit intomainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
copybara-service
bot
force-pushed
the
test_874173965
branch
from
9875509 to
f83ae9c
Compare
This allows users to unsafely mark templated types as `CRUBIT_INTERNAL_RUST_TYPE`, and they will get mapped over with 1:1 template arguments to Rust. The only check is that the template types aren't bridge types, which need a transformation. Validations like "is the layout the same?" is not performed. PiperOrigin-RevId: 874173965
copybara-service
bot
force-pushed
the
test_874173965
branch
from
f83ae9c to
593898d
Compare
copybara-service
bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow templates on crubit_internal_rust_type
This allows users to unsafely mark templated types as
CRUBIT_INTERNAL_RUST_TYPE, and they will get mapped over with 1:1 template arguments to Rust. The only check is that the template types aren't bridge types, which need a transformation.Validations like "is the layout the same?" is not performed.