Skip to content

Fix unqualified keycap sequence misclassification #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chansen wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix unqualified keycap sequence misclassification #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
23f4e94
fix: unqualified keycap sequence should be is_emoji=false
chansen May 14, 2026
2ccafd0
fix: use 0xFF as fallback category, 0x0000 collides with EMOJI
chansen May 14, 2026
def7b2d
regen: update unqualified keycap test data to is_emoji=false
chansen May 14, 2026
94a54e9
regen: regenerate scanner from updated emoji_presentation_scanner.rl
chansen May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion emoji_presentation_scanner.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ scan_emoji_presentation (emoji_text_iter_t p,
break;
case 13:
#line 102 "emoji_presentation_scanner.rl"
{te = p+1;{ *is_emoji = true; *has_vs = false; return te; }}
{te = p+1;{ *is_emoji = false; *has_vs = false; return te; }}
break;
case 8:
#line 103 "emoji_presentation_scanner.rl"
Expand Down
2 changes: 1 addition & 1 deletion emoji_presentation_scanner.rl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ text_and_emoji_run := |*
text_emoji_run_with_vs => { *is_emoji = false; *has_vs = true; return te; };
emoji_run_with_vs => { *is_emoji = true; *has_vs = true; return te; };
emoji_run => { *is_emoji = true; *has_vs = false; return te; };
unqualified_keycap_sequence => { *is_emoji = true; *has_vs = false; return te; };
unqualified_keycap_sequence => { *is_emoji = false; *has_vs = false; return te; };
text_run => { *is_emoji = false; *has_vs = false; return te; };
*|;

Expand Down
2 changes: 1 addition & 1 deletion emoji_test_data.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@
COMBINING_ENCLOSING_KEYCAP
},
.length = 2,
.is_emoji = true,
.is_emoji = false,
.has_vs = false
},
{
Expand Down
4 changes: 2 additions & 2 deletions emoji_test_data.py
100644 → 100755
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ def get_emoji_segmentation_category(cp):
return "EMOJI_EMOJI_PRESENTATION"
if regex.match(r"[[\p{Emoji}]&&[\P{Emoji_Presentation}]]", c):
return "EMOJI_TEXT_PRESENTATION"
return "0x0000"
return "0xFF"


TestUnitRx = regex.compile(
Expand Down Expand Up @@ -97,7 +97,7 @@ def write_test_data():
0031;false;false;Lone keycap base
0031 FE0E;false;true;Keycap base + VS-15 (no term)
0031 FE0F;true;true;Keycap base + VS-16 (no term)
0023 20E3;true;false;Unqualified keycap
0023 20E3;false;false;Unqualified keycap
0031 FE0E 20E3;false;true;Keycap + VS-15 + term
002A FE0F 20E3;true;true;Qualified keycap

Expand Down