Skip to content

[IfChainToSwitch] internal change #5866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: master
Choose a base branch
from
+111 −101
Open

[IfChainToSwitch] internal change #5866

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions core/src/main/java/com/google/errorprone/bugpatterns/IfChainToSwitch.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,13 +116,15 @@ public final class IfChainToSwitch extends BugChecker implements IfTreeMatcher {
private final boolean enableMain;
private final boolean enableSafe;
private final int maxChainLength;
private final int minChainLength;
private final ConstantExpressions constantExpressions;

@Inject
IfChainToSwitch(ErrorProneFlags flags, ConstantExpressions constantExpressions) {
enableMain = flags.getBoolean("IfChainToSwitch:EnableMain").orElse(false);
enableMain = flags.getBoolean("IfChainToSwitch:EnableMain").orElse(true);
enableSafe = flags.getBoolean("IfChainToSwitch:EnableSafe").orElse(false);
maxChainLength = flags.getInteger("IfChainToSwitch:MaxChainLength").orElse(50);
minChainLength = flags.getInteger("IfChainToSwitch:MinChainLength").orElse(5);
this.constantExpressions = constantExpressions;
}

Expand Down Expand Up @@ -184,7 +186,7 @@ private Description analyzeIfTree(IfTree ifTree, VisitorState state) {

if (!ifChainAnalysisState.validity().equals(Validity.VALID)
// Exclude short if-chains, since they may be more readable as-is
|| ifChainAnalysisState.depth() < 3) {
|| ifChainAnalysisState.depth() < minChainLength) {
return NO_MATCH;
}

Expand Down
Loading
Loading