Fix reassignment bug in PatternMatchingInstanceof.#5880
Merged
Conversation
Avoid refactoring if the variable assigned from the cast is reassigned, preventing compilation errors since pattern variables are implicitly `final`. Changes: - Implement `isReassigned` helper using `TreeScanner` to check for assignments, compound assignments, and unary increments/decrements. - Update `matchInstanceOf` to avoid refactoring when the cast variable is reassigned. - Add test cases to `PatternMatchingInstanceofTest` covering reassignment, increment, and compound assignment cases. - Simplify logic in `matchInstanceOf` to use a single pass loop. PiperOrigin-RevId: 933419776
copybara-service
Bot
force-pushed
the
test_933267732
branch
from
cfe95a3 to
b096ccd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix reassignment bug in PatternMatchingInstanceof.
Avoid refactoring if the variable assigned from the cast is reassigned, preventing compilation errors since pattern variables are implicitly
final.Changes:
isReassignedhelper usingTreeScannerto check for assignments, compound assignments, and unary increments/decrements.matchInstanceOfto avoid refactoring when the cast variable is reassigned.PatternMatchingInstanceofTestcovering reassignment, increment, and compound assignment cases.matchInstanceOfto use a single pass loop.