Open
Conversation
github-actions
bot
added
python
c++
grpc
codegen
aardappel
reviewed
Dec 4, 2025
fliiiix
force-pushed
the
feature/error-message-on-failed-write
branch
from
5d5568e to
475020c
Compare
Contributor
Author
|
updated and updated to latest master - ready for another review |
Contributor
Author
|
@aardappel ? @jtdavis777 any thought on this? |
Collaborator
|
Hey I've been swamped out first few weeks of the year - haven't had much free cycles. I've got a bit of a backlog but this is still on it. I also don't have merge perms anymore so everything awaits Derek now even with approvals. |
fliiiix
force-pushed
the
feature/error-message-on-failed-write
branch
from
475020c to
8139508
Compare
Contributor
Author
|
@jtdavis777 updated to latest master for consideration to get merged for the next release |
Collaborator
|
@fliiiix looks like some code gen issues? |
fliiiix
force-pushed
the
feature/error-message-on-failed-write
branch
from
8139508 to
d7aaf56
Compare
Contributor
Author
|
It was my fault it rebased it incorrectly which lead to the situation where we had code from a previous attempt - should be fixed now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on previews MR #8764 and returns proper error message when files fail to write.
eg something like this:
//cc @jtdavis777 @aardappel