Crimson Pro: Version 1.004 added #10467
Open
emmamarichal wants to merge 2 commits into
Open
Conversation
Taken from the upstream repo https://github.com/Fonthausen/CrimsonPro at commit Fonthausen/CrimsonPro@c41b427.
Contributor
FontSpector reportfontspector version: 1.6.0 Check results[12] ofl/crimsonpro/CrimsonPro-Italic[wght].ttf🔥 FAIL Ensure the font supports case swapping for all its glyphs. (case_mapping)
|
| Message | Languages |
|---|---|
| Auxiliary orthography codepoints: | * de_Latn (German) |
| The following auxiliary characters are missing from the font: ſ | |
| Auxiliary orthography codepoints: | * fr_Latn (French) |
| The following auxiliary characters are missing from the font: Ǔ | |
| The following auxiliary characters are missing from the font: ſ | |
| The following auxiliary characters are missing from the font: ǔ | |
| Auxiliary orthography codepoints: | * fi_Latn (Finnish) |
| The following auxiliary characters are missing from the font: Ǥ | |
| The following auxiliary characters are missing from the font: Ȟ | |
| The following auxiliary characters are missing from the font: Ǩ | |
| The following auxiliary characters are missing from the font: Ʒ | |
| The following auxiliary characters are missing from the font: Ǯ | |
| The following auxiliary characters are missing from the font: ǥ | |
| The following auxiliary characters are missing from the font: ȟ | |
| The following auxiliary characters are missing from the font: ǩ | |
| The following auxiliary characters are missing from the font: ʒ | |
| The following auxiliary characters are missing from the font: ǯ | |
| Auxiliary orthography codepoints: | * nb_Latn (Norwegian Bokmål) |
| The following auxiliary characters are missing from the font: Ǎ | |
| The following auxiliary characters are missing from the font: ǎ |
⚠️ WARN Ensure dotted circle glyph is present and can attach marks. (dotted_circle)
⚠️ WARN No dotted circle glyph present [code: missing-dotted-circle]
⚠️ WARN Ensure soft_dotted characters lose their dot when combined with marks that
replace the dot. (soft_dotted)
⚠️ WARN The dot of soft dotted characters used in orthographies must disappear in the following strings:
-
į̃
-
į̌
-
į̄
-
į̀
-
į́
-
į̂
-
ị̃
-
ị̄
-
ị̀
... and 2 othersThe dot of soft dotted characters should disappear in other cases, for example: -
į̊
-
į̑
-
į̒
-
į̏
-
į̈
-
į̇
-
į̋
-
į̆
-
į̉
... and 10 others [code: soft-dotted]
⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table. (googlefonts/meta/script_lang_tags)
⚠️ WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
ℹ️ INFO Familyname must be unique according to namecheck.fontdata.com (fontdata_namecheck)
- ℹ️ INFO The family name "Crimson Pro" seems to be already in use.
Please visit http://namecheck.fontdata.com/ for more info. [code: name-collision]
ℹ️ INFO Show hinting filesize impact. (hinting_impact)
- ℹ️ INFO Hinting filesize impact:
| CrimsonPro-Italic[wght].ttf | |
|---|---|
| Dehinted Size | 274244 |
| Hinted Size | 274268 |
| Increase | 24 |
| Change | 0.0 % |
ℹ️ INFO Font contains all required tables? (required_tables)
-
ℹ️ INFO This font contains the following optional tables:
loca
prep
GPOS
GSUB
gasp [code: optional-tables]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (googlefonts/gasp)
- ℹ️ INFO These are the ppm ranges declared on the gasp table:
| PPM <= 65535 | - Use grid-fitting |
| | - Use grayscale rendering |
| | - Use gridfitting with ClearType symmetric smoothing |
| - Use smoothing along multiple axes with ClearType® | |
|---|---|
| [code: ranges] |
ℹ️ INFO Font has old ttfautohint applied? (googlefonts/old_ttfautohint)
- ℹ️ INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: Version 1.004 [code: version-not-detected]
[1] ofl/crimsonpro/METADATA.pb
ℹ️ INFO Check METADATA.pb parses correctly (googlefonts/metadata/validate)
- ℹ️ INFO Please consider adding a family.minisite_url entry. [code: lacks-minisite-url]
[5] ofl/crimsonpro
🔥 FAIL METADATA.pb: Check URL on copyright string is the same as in repository_url field. (googlefonts/metadata/consistent_repo_urls)
- 🔥 FAIL Repository URL is https://github.com/Fonthausen/CrimsonPro. But:
- HTML description has 'href="https://github.com/Fonthausen/CrimsonPro">github.com/Fonthausen/CrimsonPro' [code: mismatch]
🔥 FAIL Tofu should not be shown in sample texts. (googlefonts/tofu)
- 🔥 FAIL The font has the following codepoints needed to render the specimen 16 sample text for language Aleut, but although the font contained all the base exemplars for the language, tofu will still be produced because the codepoints do not appear in any of the subsets latin-ext, latin, vietnamese:
- ̂ (U+0302) [code: missing-subsetted]
- 🔥 FAIL The font has the following codepoints needed to render the specimen 16 sample text for language Amarakaeri, but although the font contained all the codepoints for the sample text, tofu will still be produced because the codepoints do not appear in any of the subsets latin-ext, latin, vietnamese:
- ̱ (U+0331) [code: missing-subsetted]
- 🔥 FAIL The font has the following codepoints needed to render the poster md sample text for language Chickasaw, but although the font contained all the base exemplars for the language, tofu will still be produced because the codepoints do not appear in any of the subsets latin-ext, latin, vietnamese:
- ̱ (U+0331) [code: missing-subsetted]
- 🔥 FAIL The font has the following codepoints needed to render the poster md sample text for language Central Mazahua, but although the font contained all the codepoints for the sample text, tofu will still be produced because the codepoints do not appear in any of the subsets latin-ext, latin, vietnamese:
- ̱ (U+0331) [code: missing-subsetted]
- 🔥 FAIL The font has the following codepoints needed to render the poster sm sample text for language Central Mazahua, but although the font contained all the codepoints for the sample text, tofu will still be produced because the codepoints do not appear in any of the subsets latin-ext, latin, vietnamese:
- ̸ (U+0338) [code: missing-subsetted]
- 🔥 FAIL The font has the following codepoints needed to render the specimen 16 sample text for language Otomi, Mezquital, but although the font contained all the codepoints for the sample text, tofu will still be produced because the codepoints do not appear in any of the subsets latin-ext, latin, vietnamese:
- ̱ (U+0331) [code: missing-subsetted]
- 🔥 FAIL The font has the following codepoints needed to render the specimen 16 sample text for language Secoya, but although the font contained all the codepoints for the sample text, tofu will still be produced because the codepoints do not appear in any of the subsets latin-ext, latin, vietnamese:
- ̱ (U+0331) [code: missing-subsetted]
- 🔥 FAIL The font has the following codepoints needed to render the poster lg sample text for language Siona, but although the font contained all the codepoints for the sample text, tofu will still be produced because the codepoints do not appear in any of the subsets latin-ext, latin, vietnamese:
- ̱ (U+0331) [code: missing-subsetted]
- 🔥 FAIL The font has the following codepoints needed to render the specimen 16 sample text for language Ticuna, but although the font contained all the codepoints for the sample text, tofu will still be produced because the codepoints do not appear in any of the subsets latin-ext, latin, vietnamese:
- ̱ (U+0331) [code: missing-subsetted]
⚠️ WARN Check for codepoints not covered by METADATA subsets. (googlefonts/metadata/unreachable_subsetting)
⚠️ WARN ofl/crimsonpro/CrimsonPro-Italic[wght].ttf: The following codepoints supported by the font are not covered by any subsets defined in the font's metadata file, and will never be served. You can solve this by either manually adding additional subset declarations to METADATA.pb, or by editing the glyphset definitions.
- U+02D8 BREVE: try adding one of: yi, canadian-aboriginal
- U+02D9 DOT ABOVE: try adding one of: canadian-aboriginal, yi
- U+02DB OGONEK: try adding one of: canadian-aboriginal, yi
- U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: coptic, math, cherokee, tifinagh
- U+0306 COMBINING BREVE: try adding one of: old-permic, tifinagh
- U+0307 COMBINING DOT ABOVE: try adding one of: canadian-aboriginal, coptic, old-permic, hebrew, malayalam, tai-le, tifinagh, todhri, duployan, math, syriac
- U+030A COMBINING RING ABOVE: try adding one of: duployan, syriac
- U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: cherokee, osage
- U+030C COMBINING CARON: try adding one of: tai-le, cherokee
... and 58 others
Or you can add the above codepoints to one of the subsets supported by the font: latin, latin-ext, menu, vietnamese [code: unreachable-subsetting]
⚠️ WARN ofl/crimsonpro/CrimsonPro[wght].ttf: The following codepoints supported by the font are not covered by any subsets defined in the font's metadata file, and will never be served. You can solve this by either manually adding additional subset declarations to METADATA.pb, or by editing the glyphset definitions.
- U+02D8 BREVE: try adding one of: yi, canadian-aboriginal
- U+02D9 DOT ABOVE: try adding one of: canadian-aboriginal, yi
- U+02DB OGONEK: try adding one of: canadian-aboriginal, yi
- U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: coptic, math, cherokee, tifinagh
- U+0306 COMBINING BREVE: try adding one of: old-permic, tifinagh
- U+0307 COMBINING DOT ABOVE: try adding one of: canadian-aboriginal, coptic, old-permic, hebrew, malayalam, tai-le, tifinagh, todhri, duployan, math, syriac
- U+030A COMBINING RING ABOVE: try adding one of: duployan, syriac
- U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: cherokee, osage
- U+030C COMBINING CARON: try adding one of: tai-le, cherokee
... and 58 others
Or you can add the above codepoints to one of the subsets supported by the font: latin, latin-ext, menu, vietnamese [code: unreachable-subsetting]
ℹ️ INFO Check for presence of an ARTICLE.en_us.html file (googlefonts/description/has_article)
- ℹ️ INFO This font doesn't have an ARTICLE.en_us.html file. [code: missing-article]
ℹ️ INFO Check axis ordering on the STAT table. (googlefonts/STAT/axis_order)
-
ℹ️ INFO None of the fonts lack a STAT table.
And these are the most common STAT axis orderings:
wght-ital: 2 [code: summary]
[1] ofl/crimsonpro/DESCRIPTION.en_us.html
ℹ️ INFO Does DESCRIPTION file contain a upstream Git repo URL? (googlefonts/description/git_url)
- ℹ️ INFO Found a git repo URL: https://github.com/Fonthausen/CrimsonPro [code: url-found]
[13] ofl/crimsonpro/CrimsonPro[wght].ttf
🔥 FAIL Ensure the font supports case swapping for all its glyphs. (case_mapping)
- 🔥 FAIL Missing case-swapping counterpart for U+03A3 [code: missing-case-counterparts]
⚠️ WARN Detect any interpolation issues in the font. (interpolation_issues)
-
⚠️ WARN Interpolation issue in uni20B2.BRACKET.varAlt01: Wrong start point: contour 1 should start at 2 in wght=200 [code: interpolation-issue] -
⚠️ WARN Interpolation issue in uni20B2.BRACKET.varAlt01: Contour 1 becomes underweight in wght=200 compared to default [code: interpolation-issue] -
⚠️ WARN Interpolation issue in uni20B2.BRACKET.varAlt01: Wrong start point: contour 2 should start at 5 in wght=200 [code: interpolation-issue] -
⚠️ WARN Interpolation issue in uni20B2.BRACKET.varAlt01: Contour 2 becomes underweight in wght=200 compared to default [code: interpolation-issue] -
⚠️ WARN Interpolation issue in uni20B2.BRACKET.varAlt01: Wrong start point: contour 1 should start at 2 in wght=600.0122 [code: interpolation-issue] -
⚠️ WARN Interpolation issue in uni20B2.BRACKET.varAlt01: Contour 1 becomes underweight in wght=600.0122 compared to default [code: interpolation-issue] -
⚠️ WARN Interpolation issue in uni20B2.BRACKET.varAlt01: Wrong start point: contour 2 should start at 5 in wght=600.0122 [code: interpolation-issue] -
⚠️ WARN Interpolation issue in uni20B2.BRACKET.varAlt01: Contour 2 becomes underweight in wght=600.0122 compared to default [code: interpolation-issue] -
⚠️ WARN Interpolation issue in uni20B2.BRACKET.varAlt01: Wrong start point: contour 1 should start at 2 in wght=900 [code: interpolation-issue] -
⚠️ WARN Interpolation issue in uni20B2.BRACKET.varAlt01: Contour 1 becomes underweight in wght=900 compared to default [code: interpolation-issue] -
⚠️ WARN Interpolation issue in uni20B2.BRACKET.varAlt01: Wrong start point: contour 2 should start at 5 in wght=900 [code: interpolation-issue] -
⚠️ WARN Interpolation issue in uni20B2.BRACKET.varAlt01: Contour 2 becomes underweight in wght=900 compared to default [code: interpolation-issue]
⚠️ WARN Check font contains no unreachable glyphs (unreachable_glyphs)
⚠️ WARN The following glyphs could not be reached by codepoint or substitution rules:
- j.alt
- uni006A0301.alt
- NULL
- uni0326.alt [code: unreachable-glyphs]
⚠️ WARN Shapes languages in all GF glyphsets. (googlefonts/glyphsets/shape_languages)
⚠️ WARN Warning language shaping:
| Message | Languages |
|---|---|
| Auxiliary orthography codepoints: | * fi_Latn (Finnish) |
| The following auxiliary characters are missing from the font: Ǥ | |
| The following auxiliary characters are missing from the font: Ȟ | |
| The following auxiliary characters are missing from the font: Ǩ | |
| The following auxiliary characters are missing from the font: Ʒ | |
| The following auxiliary characters are missing from the font: Ǯ | |
| The following auxiliary characters are missing from the font: ǥ | |
| The following auxiliary characters are missing from the font: ȟ | |
| The following auxiliary characters are missing from the font: ǩ | |
| The following auxiliary characters are missing from the font: ʒ | |
| The following auxiliary characters are missing from the font: ǯ | |
| Auxiliary orthography codepoints: | * de_Latn (German) |
| The following auxiliary characters are missing from the font: ſ | |
| Auxiliary orthography codepoints: | * nb_Latn (Norwegian Bokmål) |
| The following auxiliary characters are missing from the font: Ǎ | |
| The following auxiliary characters are missing from the font: ǎ | |
| Auxiliary orthography codepoints: | * fr_Latn (French) |
| The following auxiliary characters are missing from the font: Ǔ | |
| The following auxiliary characters are missing from the font: ſ | |
| The following auxiliary characters are missing from the font: ǔ |
⚠️ WARN Ensure dotted circle glyph is present and can attach marks. (dotted_circle)
⚠️ WARN No dotted circle glyph present [code: missing-dotted-circle]
⚠️ WARN Ensure soft_dotted characters lose their dot when combined with marks that
replace the dot. (soft_dotted)
⚠️ WARN The dot of soft dotted characters used in orthographies must disappear in the following strings:
-
į̃
-
į̂
-
į̀
-
į̌
-
į̄
-
į́
-
ị̃
-
ị̂
-
ị̀
... and 2 othersThe dot of soft dotted characters should disappear in other cases, for example: -
į̈
-
į̇
-
į̊
-
į̆
-
į̏
-
į̑
-
į̉
-
į̒
-
į̋
... and 10 others [code: soft-dotted]
⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table. (googlefonts/meta/script_lang_tags)
⚠️ WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
ℹ️ INFO Checking OS/2 fsSelection value. (opentype/xavgcharwidth)
- ℹ️ INFO OS/2 xAvgCharWidth is 528 but it should be 527 which corresponds to the average of the widths of all glyphs in the font. These are similar values, which may be a symptom of the slightly different calculation of the xAvgCharWidth value in font editors. There's further discussion on this at com.google.fonts/test/034: xAvgCharWidth bakery vs glyphs vs font val fonttools/fontbakery#1622 [code: xAvgCharWidth-close]
ℹ️ INFO Familyname must be unique according to namecheck.fontdata.com (fontdata_namecheck)
- ℹ️ INFO The family name "Crimson Pro" seems to be already in use.
Please visit http://namecheck.fontdata.com/ for more info. [code: name-collision]
ℹ️ INFO Show hinting filesize impact. (hinting_impact)
- ℹ️ INFO Hinting filesize impact:
| CrimsonPro[wght].ttf | |
|---|---|
| Dehinted Size | 268152 |
| Hinted Size | 268176 |
| Increase | 24 |
| Change | 0.0 % |
ℹ️ INFO Font contains all required tables? (required_tables)
-
ℹ️ INFO This font contains the following optional tables:
loca
prep
GPOS
GSUB
gasp [code: optional-tables]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (googlefonts/gasp)
- ℹ️ INFO These are the ppm ranges declared on the gasp table:
| PPM <= 65535 | - Use grid-fitting |
| | - Use grayscale rendering |
| | - Use gridfitting with ClearType symmetric smoothing |
| - Use smoothing along multiple axes with ClearType® | |
|---|---|
| [code: ranges] |
ℹ️ INFO Font has old ttfautohint applied? (googlefonts/old_ttfautohint)
- ℹ️ INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: Version 1.004 [code: version-not-detected]
Summary
| 🔥 FAIL | ℹ️ INFO | ✅ PASS | ⏩ SKIP | |
|---|---|---|---|---|
| 12 | 25 | 15 | 276 | 66 |
| 3% | 7% | 4% | 74% | 18% |
Collaborator
Ldot spacing is too loose. |
emmamarichal
added
the
-- Needs Upstream Resolution
Collaborator
Author
|
PR submitted to upstream: Fonthausen/CrimsonPro#9 |
emmamarichal
removed
the
-- Needs Upstream Resolution
Contributor
FontSpector reportfontspector version: 1.7.1 Check results[1] ofl/crimsonpro/DESCRIPTION.en_us.htmlℹ️ INFO Does DESCRIPTION file contain a upstream Git repo URL? (googlefonts/description/git_url)
[13] ofl/crimsonpro/CrimsonPro-Italic[wght].ttf🔥 FAIL Ensure the font supports case swapping for all its glyphs. (case_mapping)
|
| Message | Languages |
|---|---|
| Auxiliary orthography codepoints: | * de_Latn (German) |
| The following auxiliary characters are missing from the font: ſ | |
| Auxiliary orthography codepoints: | * nb_Latn (Norwegian Bokmål) |
| The following auxiliary characters are missing from the font: Ǎ | |
| The following auxiliary characters are missing from the font: ǎ | |
| Auxiliary orthography codepoints: | * fr_Latn (French) |
| The following auxiliary characters are missing from the font: Ǔ | |
| The following auxiliary characters are missing from the font: ſ | |
| The following auxiliary characters are missing from the font: ǔ | |
| Auxiliary orthography codepoints: | * fi_Latn (Finnish) |
| The following auxiliary characters are missing from the font: Ǥ | |
| The following auxiliary characters are missing from the font: Ȟ | |
| The following auxiliary characters are missing from the font: Ǩ | |
| The following auxiliary characters are missing from the font: Ʒ | |
| The following auxiliary characters are missing from the font: Ǯ | |
| The following auxiliary characters are missing from the font: ǥ | |
| The following auxiliary characters are missing from the font: ȟ | |
| The following auxiliary characters are missing from the font: ǩ | |
| The following auxiliary characters are missing from the font: ʒ | |
| The following auxiliary characters are missing from the font: ǯ |
⚠️ WARN Ensure dotted circle glyph is present and can attach marks. (dotted_circle)
⚠️ WARN No dotted circle glyph present [code: missing-dotted-circle]
⚠️ WARN Ensure soft_dotted characters lose their dot when combined with marks that
replace the dot. (soft_dotted)
⚠️ WARN The dot of soft dotted characters used in orthographies must disappear in the following strings:
-
į̀
-
į̌
-
į̄
-
į̃
-
į̂
-
į́
-
ị̀
-
ị̄
-
ị̃
... and 2 othersThe dot of soft dotted characters should disappear in other cases, for example: -
į̒
-
į̋
-
į̉
-
į̇
-
į̆
-
į̊
-
į̏
-
į̈
-
į̑
... and 10 others [code: soft-dotted]
⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table. (googlefonts/meta/script_lang_tags)
⚠️ WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
ℹ️ INFO Checking OS/2 fsSelection value. (opentype/xavgcharwidth)
- ℹ️ INFO OS/2 xAvgCharWidth is 513 but it should be 512 which corresponds to the average of the widths of all glyphs in the font. These are similar values, which may be a symptom of the slightly different calculation of the xAvgCharWidth value in font editors. There's further discussion on this at com.google.fonts/test/034: xAvgCharWidth bakery vs glyphs vs font val fonttools/fontbakery#1622 [code: xAvgCharWidth-close]
ℹ️ INFO Familyname must be unique according to namecheck.fontdata.com (fontdata_namecheck)
- ℹ️ INFO The family name "Crimson Pro" seems to be already in use.
Please visit http://namecheck.fontdata.com/ for more info. [code: name-collision]
ℹ️ INFO Show hinting filesize impact. (hinting_impact)
- ℹ️ INFO Hinting filesize impact:
| CrimsonPro-Italic[wght].ttf | |
|---|---|
| Dehinted Size | 274688 |
| Hinted Size | 274712 |
| Increase | 24 |
| Change | 0.0 % |
ℹ️ INFO Font contains all required tables? (required_tables)
-
ℹ️ INFO This font contains the following optional tables:
loca
prep
GPOS
GSUB
gasp [code: optional-tables]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (googlefonts/gasp)
- ℹ️ INFO These are the ppm ranges declared on the gasp table:
| PPM <= 65535 | - Use grid-fitting |
| | - Use grayscale rendering |
| | - Use gridfitting with ClearType symmetric smoothing |
| - Use smoothing along multiple axes with ClearType® | |
|---|---|
| [code: ranges] |
ℹ️ INFO Font has old ttfautohint applied? (googlefonts/old_ttfautohint)
- ℹ️ INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: Version 1.004 [code: version-not-detected]
[1] ofl/crimsonpro/METADATA.pb
ℹ️ INFO Check METADATA.pb parses correctly (googlefonts/metadata/validate)
- ℹ️ INFO Please consider adding a family.minisite_url entry. [code: lacks-minisite-url]
[5] ofl/crimsonpro
🔥 FAIL METADATA.pb: Check URL on copyright string is the same as in repository_url field. (googlefonts/metadata/consistent_repo_urls)
- 🔥 FAIL Repository URL is https://github.com/Fonthausen/CrimsonPro. But:
- HTML description has 'href="https://github.com/Fonthausen/CrimsonPro">github.com/Fonthausen/CrimsonPro' [code: mismatch]
🔥 FAIL Tofu should not be shown in sample texts. (googlefonts/tofu)
- 🔥 FAIL The font has the following codepoints needed to render the specimen 16 sample text for language Aleut, but although the font contained all the base exemplars for the language, tofu will still be produced because the codepoints do not appear in any of the subsets latin-ext, latin, vietnamese:
- ̂ (U+0302) [code: missing-subsetted]
- 🔥 FAIL The font has the following codepoints needed to render the specimen 16 sample text for language Amarakaeri, but although the font contained all the codepoints for the sample text, tofu will still be produced because the codepoints do not appear in any of the subsets latin-ext, latin, vietnamese:
- ̱ (U+0331) [code: missing-subsetted]
- 🔥 FAIL The font has the following codepoints needed to render the poster md sample text for language Chickasaw, but although the font contained all the base exemplars for the language, tofu will still be produced because the codepoints do not appear in any of the subsets latin-ext, latin, vietnamese:
- ̱ (U+0331) [code: missing-subsetted]
- 🔥 FAIL The font has the following codepoints needed to render the poster md sample text for language Central Mazahua, but although the font contained all the codepoints for the sample text, tofu will still be produced because the codepoints do not appear in any of the subsets latin-ext, latin, vietnamese:
- ̱ (U+0331) [code: missing-subsetted]
- 🔥 FAIL The font has the following codepoints needed to render the poster sm sample text for language Central Mazahua, but although the font contained all the codepoints for the sample text, tofu will still be produced because the codepoints do not appear in any of the subsets latin-ext, latin, vietnamese:
- ̸ (U+0338) [code: missing-subsetted]
- 🔥 FAIL The font has the following codepoints needed to render the specimen 16 sample text for language Otomi, Mezquital, but although the font contained all the codepoints for the sample text, tofu will still be produced because the codepoints do not appear in any of the subsets latin-ext, latin, vietnamese:
- ̱ (U+0331) [code: missing-subsetted]
- 🔥 FAIL The font has the following codepoints needed to render the specimen 16 sample text for language Secoya, but although the font contained all the codepoints for the sample text, tofu will still be produced because the codepoints do not appear in any of the subsets latin-ext, latin, vietnamese:
- ̱ (U+0331) [code: missing-subsetted]
- 🔥 FAIL The font has the following codepoints needed to render the poster lg sample text for language Siona, but although the font contained all the codepoints for the sample text, tofu will still be produced because the codepoints do not appear in any of the subsets latin-ext, latin, vietnamese:
- ̱ (U+0331) [code: missing-subsetted]
- 🔥 FAIL The font has the following codepoints needed to render the specimen 16 sample text for language Ticuna, but although the font contained all the codepoints for the sample text, tofu will still be produced because the codepoints do not appear in any of the subsets latin-ext, latin, vietnamese:
- ̱ (U+0331) [code: missing-subsetted]
⚠️ WARN Check for codepoints not covered by METADATA subsets. (googlefonts/metadata/unreachable_subsetting)
⚠️ WARN ofl/crimsonpro/CrimsonPro-Italic[wght].ttf: The following codepoints supported by the font are not covered by any subsets defined in the font's metadata file, and will never be served. You can solve this by either manually adding additional subset declarations to METADATA.pb, or by editing the glyphset definitions.
- U+02D8 BREVE: try adding one of: canadian-aboriginal, yi
- U+02D9 DOT ABOVE: try adding one of: yi, canadian-aboriginal
- U+02DB OGONEK: try adding one of: yi, canadian-aboriginal
- U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: cherokee, coptic, math, tifinagh
- U+0306 COMBINING BREVE: try adding one of: tifinagh, old-permic
- U+0307 COMBINING DOT ABOVE: try adding one of: old-permic, duployan, math, coptic, syriac, malayalam, tifinagh, todhri, tai-le, canadian-aboriginal, hebrew
- U+030A COMBINING RING ABOVE: try adding one of: duployan, syriac
- U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: osage, cherokee
- U+030C COMBINING CARON: try adding one of: tai-le, cherokee
... and 58 others
Or you can add the above codepoints to one of the subsets supported by the font: latin, latin-ext, menu, vietnamese [code: unreachable-subsetting]
⚠️ WARN ofl/crimsonpro/CrimsonPro[wght].ttf: The following codepoints supported by the font are not covered by any subsets defined in the font's metadata file, and will never be served. You can solve this by either manually adding additional subset declarations to METADATA.pb, or by editing the glyphset definitions.
- U+02D8 BREVE: try adding one of: canadian-aboriginal, yi
- U+02D9 DOT ABOVE: try adding one of: yi, canadian-aboriginal
- U+02DB OGONEK: try adding one of: yi, canadian-aboriginal
- U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: cherokee, coptic, math, tifinagh
- U+0306 COMBINING BREVE: try adding one of: tifinagh, old-permic
- U+0307 COMBINING DOT ABOVE: try adding one of: old-permic, duployan, math, coptic, syriac, malayalam, tifinagh, todhri, tai-le, canadian-aboriginal, hebrew
- U+030A COMBINING RING ABOVE: try adding one of: duployan, syriac
- U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: osage, cherokee
- U+030C COMBINING CARON: try adding one of: tai-le, cherokee
... and 58 others
Or you can add the above codepoints to one of the subsets supported by the font: latin, latin-ext, menu, vietnamese [code: unreachable-subsetting]
ℹ️ INFO Check for presence of an ARTICLE.en_us.html file (googlefonts/description/has_article)
- ℹ️ INFO This font doesn't have an ARTICLE.en_us.html file. [code: missing-article]
ℹ️ INFO Check axis ordering on the STAT table. (googlefonts/STAT/axis_order)
-
ℹ️ INFO None of the fonts lack a STAT table.
And these are the most common STAT axis orderings:
wght-ital: 2 [code: summary]
[13] ofl/crimsonpro/CrimsonPro[wght].ttf
🔥 FAIL Ensure the font supports case swapping for all its glyphs. (case_mapping)
- 🔥 FAIL Missing case-swapping counterpart for U+03A3 [code: missing-case-counterparts]
⚠️ WARN Detect any interpolation issues in the font. (interpolation_issues)
-
⚠️ WARN Interpolation issue in uni20B2.BRACKET.varAlt01: Wrong start point: contour 2 should start at 5 in wght=200 [code: interpolation-issue] -
⚠️ WARN Interpolation issue in uni20B2.BRACKET.varAlt01: Contour 2 becomes underweight in wght=200 compared to default [code: interpolation-issue] -
⚠️ WARN Interpolation issue in uni20B2.BRACKET.varAlt01: Wrong start point: contour 2 should start at 5 in wght=600.0122 [code: interpolation-issue] -
⚠️ WARN Interpolation issue in uni20B2.BRACKET.varAlt01: Contour 2 becomes underweight in wght=600.0122 compared to default [code: interpolation-issue] -
⚠️ WARN Interpolation issue in uni20B2.BRACKET.varAlt01: Wrong start point: contour 2 should start at 5 in wght=900 [code: interpolation-issue] -
⚠️ WARN Interpolation issue in uni20B2.BRACKET.varAlt01: Contour 2 becomes underweight in wght=900 compared to default [code: interpolation-issue]
⚠️ WARN Check font contains no unreachable glyphs (unreachable_glyphs)
⚠️ WARN The following glyphs could not be reached by codepoint or substitution rules:
- j.alt
- uni006A0301.alt
- NULL
- uni0326.alt [code: unreachable-glyphs]
⚠️ WARN Shapes languages in all GF glyphsets. (googlefonts/glyphsets/shape_languages)
⚠️ WARN Warning language shaping:
| Message | Languages |
|---|---|
| Auxiliary orthography codepoints: | * fi_Latn (Finnish) |
| The following auxiliary characters are missing from the font: Ǥ | |
| The following auxiliary characters are missing from the font: Ȟ | |
| The following auxiliary characters are missing from the font: Ǩ | |
| The following auxiliary characters are missing from the font: Ʒ | |
| The following auxiliary characters are missing from the font: Ǯ | |
| The following auxiliary characters are missing from the font: ǥ | |
| The following auxiliary characters are missing from the font: ȟ | |
| The following auxiliary characters are missing from the font: ǩ | |
| The following auxiliary characters are missing from the font: ʒ | |
| The following auxiliary characters are missing from the font: ǯ | |
| Auxiliary orthography codepoints: | * fr_Latn (French) |
| The following auxiliary characters are missing from the font: Ǔ | |
| The following auxiliary characters are missing from the font: ſ | |
| The following auxiliary characters are missing from the font: ǔ | |
| Auxiliary orthography codepoints: | * nb_Latn (Norwegian Bokmål) |
| The following auxiliary characters are missing from the font: Ǎ | |
| The following auxiliary characters are missing from the font: ǎ | |
| Auxiliary orthography codepoints: | * de_Latn (German) |
| The following auxiliary characters are missing from the font: ſ |
⚠️ WARN Ensure dotted circle glyph is present and can attach marks. (dotted_circle)
⚠️ WARN No dotted circle glyph present [code: missing-dotted-circle]
⚠️ WARN Ensure soft_dotted characters lose their dot when combined with marks that
replace the dot. (soft_dotted)
⚠️ WARN The dot of soft dotted characters used in orthographies must disappear in the following strings:
-
ị́
-
ị̂
-
ị̃
-
ị̀
-
ị̄
-
į́
-
į̂
-
į̃
-
į̀
... and 2 othersThe dot of soft dotted characters should disappear in other cases, for example: -
ị̋
-
ị̏
-
ị̇
-
ị̑
-
ị̊
-
ị̈
-
ị̉
-
ị̒
-
ị̌
... and 10 others [code: soft-dotted]
⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table. (googlefonts/meta/script_lang_tags)
⚠️ WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
ℹ️ INFO Checking OS/2 fsSelection value. (opentype/xavgcharwidth)
- ℹ️ INFO OS/2 xAvgCharWidth is 527 but it should be 526 which corresponds to the average of the widths of all glyphs in the font. These are similar values, which may be a symptom of the slightly different calculation of the xAvgCharWidth value in font editors. There's further discussion on this at com.google.fonts/test/034: xAvgCharWidth bakery vs glyphs vs font val fonttools/fontbakery#1622 [code: xAvgCharWidth-close]
ℹ️ INFO Familyname must be unique according to namecheck.fontdata.com (fontdata_namecheck)
- ℹ️ INFO The family name "Crimson Pro" seems to be already in use.
Please visit http://namecheck.fontdata.com/ for more info. [code: name-collision]
ℹ️ INFO Show hinting filesize impact. (hinting_impact)
- ℹ️ INFO Hinting filesize impact:
| CrimsonPro[wght].ttf | |
|---|---|
| Dehinted Size | 268488 |
| Hinted Size | 268512 |
| Increase | 24 |
| Change | 0.0 % |
ℹ️ INFO Font contains all required tables? (required_tables)
-
ℹ️ INFO This font contains the following optional tables:
loca
prep
GPOS
GSUB
gasp [code: optional-tables]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (googlefonts/gasp)
- ℹ️ INFO These are the ppm ranges declared on the gasp table:
| PPM <= 65535 | - Use grid-fitting |
| | - Use grayscale rendering |
| | - Use gridfitting with ClearType symmetric smoothing |
| - Use smoothing along multiple axes with ClearType® | |
|---|---|
| [code: ranges] |
ℹ️ INFO Font has old ttfautohint applied? (googlefonts/old_ttfautohint)
- ℹ️ INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: Version 1.004 [code: version-not-detected]
Summary
| 🔥 FAIL | ℹ️ INFO | ✅ PASS | ⏩ SKIP | |
|---|---|---|---|---|
| 12 | 19 | 16 | 275 | 66 |
| 3% | 5% | 4% | 74% | 18% |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Taken from the upstream repo https://github.com/Fonthausen/CrimsonPro at commit Fonthausen/CrimsonPro@c41b427.
PR Checklist:
PR
QA
Specifics
primary_scriptdefinition in the METADATA.pb file for all projects that have a primary non-Latin based language support targetsubsetsdefinitions in the METADATA.pb reflect the actual subsets and languages present in the font files (in alphabetic order). For CJK fonts, only include one of the following subsetschinese-hongkong,chinese-simplified,chinese-traditional,korean,japanese.Release
minisite_urldefinition in the METADATA.pb file for commissioned projectstagsare added for NEW FONTS