feat!: Implement Enterprise SCIM - Provision Groups & Users #3852
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3852 +/- ##
==========================================
+ Coverage 92.40% 92.41% +0.01%
==========================================
Files 200 200
Lines 14410 14432 +22
==========================================
+ Hits 13315 13337 +22
Misses 895 895
Partials 200 200 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gmlewis
changed the title
gmlewis
added
the
Breaking API Change
gmlewis
left a comment
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @elminster-aom!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
cc: @stevehipwell - @alexandear - @zyfy29
Fix typo on the `CIMEnterpriseGroupAttributes` struct documentation. Co-authored-by: Steve Hipwell <steve.hipwell@gmail.com>
|
@gmlewis Do I need to take action regarding this drop of -0.10% for |
No, thank you though, @elminster-aom. The Codecov reports are mostly informational, and I'm not always convinced that they are helpful. Sometimes it will catch cases where unit tests could have added a |
|
@elminster-aom - it looks like some conflicts have emerged from other merges. Would you like to address them, or would you like me to do that? I'm fine either way. Some people like a fun challenge, others don't. 😂 Your call. |
* forkstream/master: chore!: Remove `PullRequestRuleParameters.AutomaticCopilotCodeReviewEnabled` field (google#3866) feat: Add support for `copilot_code_review` rule type (google#3857) feat: Implement Enterprise SCIM - Delete Groups or Users (google#3856) feat: Add `advanced_search` parameter to `SearchOptions` (google#3868) fix!: Change Org usage report `Quantity` to `float64` (google#3862) build(deps): Bump actions/checkout from 6.0.0 to 6.0.1 in the actions group (google#3863) build(deps): Bump golang.org/x/sync from 0.18.0 to 0.19.0 in /tools (google#3864) build(deps): Bump golang.org/x/term from 0.37.0 to 0.38.0 in /example (google#3865) feat: Implement Enterprise SCIM - Set Groups or Users (google#3858) feat: Add support for Enterprise Team APIs (google#3861) Bump go-github from v79 to v80 in /scrape (google#3855) Bump version of go-github to v80.0.0 (google#3854) feat: Add repository target to ruleset (google#3850)
Sure. Always the fanny option for me, of course 😁 . Thanks @gmlewis |
|
Thank you, @stevehipwell and @elminster-aom! |
3 participants
BREAKING CHANGE:
SCIMEnterpriseDisplayReference.Refis now of type*string.Related with #3813
From REST API endpoints for Enterprise SCIM docs, implements:
Provision a SCIM enterprise group, POST /scim/v2/enterprises/{enterprise}/Groups
Provision a SCIM enterprise user, POST /scim/v2/enterprises/{enterprise}/Users
Breaking API change
When provisioning Groups, the
SCIMEnterpriseDisplayReference.Refis optional for provisioning actions so it changed to pointer.