Skip to content

lint: Improve extraneousnew linter to catch unnecessary use of value var#4249

Merged
gmlewis merged 4 commits into
google:masterfrom
gmlewis:i4244-linter
May 22, 2026
Merged

lint: Improve extraneousnew linter to catch unnecessary use of value var#4249
gmlewis merged 4 commits into
google:masterfrom
gmlewis:i4244-linter

Conversation

@gmlewis
Copy link
Copy Markdown
Collaborator

@gmlewis gmlewis commented May 22, 2026

Fixes: #4244.

…e var

Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label May 22, 2026
@gmlewis
Copy link
Copy Markdown
Collaborator Author

gmlewis commented May 22, 2026

@codecov
Copy link
Copy Markdown

codecov Bot commented May 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.48%. Comparing base (6ac8fe4) to head (1784b27).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4249      +/-   ##
==========================================
+ Coverage   97.46%   97.48%   +0.02%     
==========================================
  Files         190      190              
  Lines       19178    19178              
==========================================
+ Hits        18691    18695       +4     
+ Misses        270      268       -2     
+ Partials      217      215       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

gmlewis added 3 commits May 21, 2026 21:48
Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label May 22, 2026
@gmlewis
Copy link
Copy Markdown
Collaborator Author

gmlewis commented May 22, 2026

Thank you, @alexandear!
Merging.

@gmlewis gmlewis merged commit c207b27 into google:master May 22, 2026
14 checks passed
@gmlewis gmlewis deleted the i4244-linter branch May 22, 2026 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The extraneousnew linter is missing a case

2 participants