test: cover actions permission JSON marshalling#4250
Open
KirtiRamchandani wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4250 +/- ##
=======================================
Coverage 97.48% 97.48%
=======================================
Files 190 190
Lines 19178 19178
=======================================
Hits 18695 18695
Misses 268 268
Partials 215 215 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Issue #55 tracks adding JSON marshal coverage for public resource types that implement
String().Root cause
Several Actions permission-related response types had
String()implementations but no matching marshal tests, leaving their JSON field names and omitted-empty behavior uncovered.Solution
Add marshal tests for the remaining Actions permission and retention structs in the existing test files:
ArtifactPeriodActionsPermissionsEnterpriseSelfHostRunnerPermissionsEnterpriseSelfHostedRunnersSettingsOrganizationWorkflowsPermissionsContributorApprovalPermissionsTests
go test ./github -run 'Test(ArtifactPeriod|ActionsPermissionsEnterprise|SelfHostRunnerPermissionsEnterprise|SelfHostedRunnersSettingsOrganization|WorkflowsPermissions|ContributorApprovalPermissions)_Marshal'go test ./githubgo test ./...git diff --checkFixes part of #55.