chore: Add dependency graph marshal tests#4254
Open
KirtiRamchandani wants to merge 2 commits into
Open
Conversation
gmlewis
requested changes
May 26, 2026
| @@ -0,0 +1,371 @@ | |||
| // Copyright 2023 The go-github AUTHORS. All rights reserved. | |||
Collaborator
There was a problem hiding this comment.
Instead of creating a new file for this, please delete this file and add the tests to the end of the already-existing dependency_graph_test.go.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4254 +/- ##
=======================================
Coverage 97.48% 97.48%
=======================================
Files 190 190
Lines 19178 19178
=======================================
Hits 18695 18695
Misses 268 268
Partials 215 215 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Author
|
Thanks, moved the marshal tests into the existing dependency_graph_test.go file and removed the standalone test file. Reran the focused marshal test group, go test ./github, go test ./..., and git diff --check. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Dependency graph and SBOM resource structs are newer API payloads, but their JSON marshal behavior was not covered by the resource-level marshal tests tracked by #55.
Root cause
The existing dependency graph tests focus on service request/response behavior. They do not round-trip the shared SBOM, dependency snapshot, manifest, detector, job, and creation response structs directly.
Solution
Add focused marshal tests for empty and populated dependency graph resource types, including SBOM metadata, package external refs, relationships, snapshot manifests, resolved dependencies, and snapshot creation data.
Tests run
Linked issue
Part of #55