Repository navigation
feat: Add RequireExtraApprovalForUnattributedChanges to PullRequestRuleParameters - #4653
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4653 +/- ##
=======================================
Coverage 98.63% 98.63%
=======================================
Files 201 201
Lines 18867 18867
=======================================
Hits 18609 18609
Misses 258 258 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Thanks @gmlewis, really appreciate it, especially given the circumstances 🙏 |
|
@outring I couldn't find the |
|
@Not-Dhananjay-Mishra it's a known GH issue, in fact they're there though 🫠 |
Not-Dhananjay-Mishra
left a comment
There was a problem hiding this comment.
LGTM 🚀, Thanks @outring, for sharing the issue link!
|
Thank you, @Not-Dhananjay-Mishra! |
|
Thanks everyone for the quick review and merge! Really appreciate the fast turnaround 🙏 |
Adds the
require_extra_approval_for_unattributed_changesruleset setting (docs).RequireExtraApprovalForUnattributedChangestoPullRequestRuleParametersCode, tests and this description were drafted with Claude.