Skip to content

feat: Add RequireExtraApprovalForUnattributedChanges to PullRequestRuleParameters - #4653

Merged
gmlewis merged 2 commits into
google:masterfrom
outring:require-extra-approval-unattributed
Oct 22, 2026
Merged

gmlewis merged 2 commits into
google:masterfrom
outring:require-extra-approval-unattributed

Conversation

@outring

@outring outring commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

Adds the require_extra_approval_for_unattributed_changes ruleset setting (docs).

  1. Add RequireExtraApprovalForUnattributedChanges to PullRequestRuleParameters
  2. Regenerate accessors
  3. Extend rules test fixtures

Code, tests and this description were drafted with Claude.

@google-cla

google-cla Bot commented Oct 20, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@codecov

codecov Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.63%. Comparing base (2190e6a) to head (90d7720).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4653   +/-   ##
=======================================
  Coverage   98.63%   98.63%           
=======================================
  Files         201      201           
  Lines       18867    18867           
=======================================
  Hits        18609    18609           
  Misses        258      258           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Oct 21, 2026

@gmlewis gmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @outring.
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.

cc: @stevehipwell - @Not-Dhananjay-Mishra

@outring

outring commented Oct 21, 2026

Copy link
Copy Markdown
Contributor Author

Thanks @gmlewis, really appreciate it, especially given the circumstances 🙏

@Not-Dhananjay-Mishra

Copy link
Copy Markdown
Contributor

@outring I couldn't find the require_extra_approval_for_unattributed_changes field in the response schemas of the endpoints documented at https://docs.github.com/en/rest/orgs/rules?apiVersion=2022-11-28 or in the OpenAPI specs.

@outring

outring commented Oct 22, 2026

Copy link
Copy Markdown
Contributor Author

@Not-Dhananjay-Mishra it's a known GH issue, in fact they're there though 🫠

@Not-Dhananjay-Mishra Not-Dhananjay-Mishra left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀, Thanks @outring, for sharing the issue link!

@gmlewis

gmlewis commented Oct 22, 2026

Copy link
Copy Markdown
Collaborator

Thank you, @Not-Dhananjay-Mishra!
Merging.

@gmlewis
gmlewis merged commit b48c264 into google:master Oct 22, 2026
15 checks passed
@outring

outring commented Oct 22, 2026

Copy link
Copy Markdown
Contributor Author

Thanks everyone for the quick review and merge! Really appreciate the fast turnaround 🙏

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Oct 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants