Document ArrayStoreException in ObjectArrays.concat methods#8095
Open
stevearmstrong-dev wants to merge 1 commit intogoogle:masterfrom
Open
Conversation
Add @throws ArrayStoreException documentation to concat(T, T[]) and concat(T[], T) methods to clarify when this exception can occur at runtime. Also add test cases that demonstrate and document this behavior. Addresses issue google#3768
netdpb
added
type=api-docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@throws ArrayStoreExceptiondocumentation toconcat(T, T[])andconcat(T[], T)methodsMotivation
Addresses issue #3768 - these methods can throw
ArrayStoreExceptionat runtime when incompatible types are passed, but this behavior was not documented in the Javadoc.Changes
@throwstags explaining when ArrayStoreException occurstestPrependIncompatibleType_throwsArrayStoreException()andtestAppendIncompatibleType_throwsArrayStoreException()to verify and document the behaviorRelated Issue
Closes #3768