refactor: Clarify the logic in line_group's grouping function.#108
Merged
refactor: Clarify the logic in line_group's grouping function.#108
Conversation
I think this is somewhat easier to understand, at least at face value. It's a little unfortunate that you still need to dive into the implementation of `shouldAddToGroup` to understand the interplay with `numUnmatchedStartDirectives`, but I think this is still a net positive.
KatrinaHoffert
approved these changes
Feb 24, 2026
Member
KatrinaHoffert
left a comment
KatrinaHoffert
left a comment
There was a problem hiding this comment.
I see what you mean about the unfortunate part, but agree it's a net benefit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this is somewhat easier to understand, at least at face value.
It's a little unfortunate that you still need to dive into the implementation of
shouldAddToGroupto understand the interplay withnumUnmatchedStartDirectives, but I think this is still a net positive.