Add honest Kotoba v1 E.164-looking check surface - #4072
Open
com-junkawasaki wants to merge 2 commits into
Open
Conversation
Sibling kotoba/ tree with a plus-prefix digit-length check, two testdata accept fixtures, two reject fixtures, and fork CI for kotoba CLI 0.7.2 wasm32 i64-v1. Not a metadata/carrier/geocoding port. Co-authored-by: Jun Kawasaki <04.feasts_minded@icloud.com>
Add pull_request path filters: kotoba-v1.yml runs on kotoba/** only; java-test, cpp-test, CodeQL, and the other jobs this PR woke ignore kotoba-only diffs. Co-authored-by: Jun Kawasaki <04.feasts_minded@icloud.com>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Honest Kotoba v1 sibling under
kotoba/. Plus prefix plus digit length 2..15 only. NotisValidNumber, not metadata/carrier/geocoding, not a Java/C++/JS replacement, no FFI.Fork PR: kotoba-lang#1
kotoba-oss QA observed the fork job
kotoba compile + fixtureSUCCESS. This PR does not claim a wasm byte size.Google CLA may apply; it is not filed here.
Test plan
bash kotoba/checks.sh(requireskotoba.cli/code == emittedand no wasm import section)+16502530000/+442070313000; reject spaced international and NSN