Add ppc64le and s390x to recognized architectures#376
Add ppc64le and s390x to recognized architectures#376kleisauke wants to merge 1 commit intogoogle:mainfrom
Conversation
|
Alternatively, here's a changeset that removes the platform and architecture detection logic (including the arch-specific flags): For example, this allows building for a Raspberry Pi Zero W (ARMv6). Without this change, the build fails with: (and this is just one case, there are likely better examples of why injecting those flags is not advisable) |
FWIW, build on Fedora 43 w/ GCC 15 fails w/ presumably because the forced Interestingly, linking luckily works out w/ the newer GCC 16 toolchain in Fedora 44 - I guess it now somehow figures out better it actually needs to link |
It may be related to automatic linking of libatomic in GCC 16. ref: gcc-mirror/gcc@e63cf4b |
|
@topazus I feel the alternative of removing |
|
Closing in favor of #383. |
See for example:
https://github.com/kleisauke/libvips-packaging/actions/runs/20065009063/job/57551203630
https://github.com/kleisauke/libvips-packaging/actions/runs/20065009063/job/57551203641
Note that I considered adding architecture-specific compile flags, similar to what's done here:
libultrahdr/CMakeLists.txt
Lines 295 to 323 in 8cbc983
However, I don't think that makes much sense, as Linux distributions usually handle this themselves.