fix(secops-soar): resolve marketplace imports and synchronize setup.py (#293, #294) - #295
Open
dandye wants to merge 1 commit into
Open
fix(secops-soar): resolve marketplace imports and synchronize setup.py (#293, #294)#295dandye wants to merge 1 commit into
dandye wants to merge 1 commit into
Conversation
This was referenced Aug 30, 2026
dandye
force-pushed
the
fix/soar-client-errors
branch
from
September 7, 2026 15:13
d900bb6 to
9142e93
Compare
dandye
changed the title
…y dependencies (#293, #294) - Update dynamic tool registration to import via secops_soar_mcp.marketplace.{stem} with fallback to marketplace.{stem} (Fixes #293) - Add python-dotenv>=1.0.0 to setup.py install_requires to match pyproject.toml (Fixes #294) - Add unit tests in tests/unit/test_marketplace_and_packaging.py verifying import resolution and dependency synchronization
dandye
force-pushed
the
fix/soar-client-errors
branch
from
September 7, 2026 15:22
9142e93 to
aa9e817
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses marketplace module import resolution and packaging synchronization across
server/secops-soar:Dynamic Marketplace Module Import Resolution (Fixes [secops-soar] Dynamic marketplace tool import fails with ModuleNotFoundError when running installed package #293):
secops_soar_mcp/server.pyto resolve marketplace integration tools via qualified package pathsecops_soar_mcp.marketplace.{module_stem}with fallback tomarketplace.{module_stem}.ModuleNotFoundError: No module named 'marketplace'whensecops-soar-mcpis installed as a package or executed from arbitrary working directories.Synchronize
python-dotenvinsetup.py(Fixes [secops-soar] setup.py is missing python-dotenv dependency from install_requires #294):"python-dotenv>=1.0.0"toinstall_requiresinserver/secops-soar/setup.pyto matchpyproject.toml.setup.pypull inpython-dotenvrequired bysecops_soar_mcp.bindings.Hermetic Unit Tests:
server/secops-soar/tests/unit/test_marketplace_and_packaging.pytesting qualified and fallback module imports, tool registration, andsetup.pydependency declaration.(Note: Prior commits addressing SOAR TLS/certifi startup diagnostics for #191 were superseded by merged PR #308 and were removed during rebase onto main.)
Fixes #293
Fixes #294
Tests Run
uv run --with "mcp<2" --with pytest --with pytest-asyncio --with aiohttp --with python-dotenv pytest server/secops-soar/tests/unit/ -v(8 passed)uv run --with ruff ruff check server/secops-soar/tests/unit/test_marketplace_and_packaging.py(All checks passed)