Factor permutation management in a class#558
Merged
Merged
Conversation
mtrofin
force-pushed
the
main
branch
3 times, most recently
from
301aad4 to
e0b1cfc
Compare
| self._is_antithetic = is_antithetic | ||
| self._rng = np.random.default_rng(seed=seed) | ||
|
|
||
| def get_next_perturbations(self) -> list[npt.NDArray[np.float32]]: |
Collaborator
There was a problem hiding this comment.
Nit: Are these necessarily next? There's no actual state here.
Collaborator
Author
There was a problem hiding this comment.
but every time you call it you get something else. next suggests that.
Collaborator
There was a problem hiding this comment.
next to me implies state. Maybe something like new would work better?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Besides factoring, this also addresses 2 problems: