Add behavioral cloning step#560
Open
beamandala wants to merge 1 commit into
Open
Conversation
mtrofin
reviewed
May 29, 2026
| --gin_bindings inlining.config.get_observation_processing_layer_creator.quantile_file_dir="'/work/corpus/vocab'" \ | ||
| --gin_bindings pretrained_policy_path="'/work/corpus/bc_model/saved_policy'" \ | ||
| --output_path /work/corpus/trained_model_es | ||
| # --gin_bindings BlackboxLearnerConfig.total_steps=2 \ |
Collaborator
There was a problem hiding this comment.
we probably want more steps and perturbations. or you mean to bump these later?
Author
There was a problem hiding this comment.
I left most variables unpopulated under the assumption that the defaults were good enough. Are they not? If they're not good enough what do you recommend?
mtrofin
reviewed
May 29, 2026
| --root_dir /work/corpus/bc_model \ | ||
| --gin_files /work/ml-compiler-opt/compiler_opt/rl/inlining/gin_configs/behavioral_cloning_nn_agent.gin \ | ||
| --gin_bindings inlining.config.get_observation_processing_layer_creator.quantile_file_dir="'/work/corpus/vocab'" \ | ||
| # --gin_bindings train_eval.num_iterations=5000 \ |
Collaborator
There was a problem hiding this comment.
remove comment or keep the line?
| @@ -0,0 +1,317 @@ | |||
| #!/bin/bash | |||
| --llvm_objcopy_path /work/llvm-train/bin/llvm-objcopy \ | ||
| --obj_base_dir /work/llvm-corpus | ||
| --obj_base_dir /work/llvm-corpus \ | ||
| # --num_workers=4 |
beamandala
force-pushed
the
bhavesh/complete-demo
branch
from
16a778e to
f70a56e
Compare
beamandala
force-pushed
the
bhavesh/complete-demo
branch
from
f70a56e to
36ab923
Compare
beamandala
force-pushed
the
bhavesh/complete-demo
branch
from
36ab923 to
06a1897
Compare
beamandala
changed the title
Collaborator
|
overall lgtm, but remove commented lines (the ones that if uncommented would change a flag, specifically.) |
boomanaiden154
approved these changes
Jun 2, 2026
Collaborator
boomanaiden154
left a comment
boomanaiden154
left a comment
There was a problem hiding this comment.
LGTM minus two nits.
|
|
||
| ## 1. Build the Docker Image | ||
|
|
||
| From the repository root, build the development environment container: |
Collaborator
There was a problem hiding this comment.
Nit: s/development/demo or something.
Development environment to me means experiment/docker/development.Dockerfile.
| Run the container with volume mounts to persist corpus data, training logs, and checkpoints locally. This enables running TensorBoard on the host to monitor training. | ||
|
|
||
| ```bash | ||
| sudo docker run -it \ |
Collaborator
There was a problem hiding this comment.
Sudo here but not above? We should probably omit it here.
mtrofin
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.