Remove Contact and ContactHistory Java objects and related code#2964
Merged
gbrodman merged 1 commit intogoogle:masterfrom Feb 20, 2026
Merged
Remove Contact and ContactHistory Java objects and related code#2964gbrodman merged 1 commit intogoogle:masterfrom
gbrodman merged 1 commit intogoogle:masterfrom
Conversation
This doesn't remove everything -- there are still other contact-related objects that we'll need to remove (e.g. ContactPendingActionNotificationResponse) and simplifications we'll need to make (e.g. only domains can be transferred now, so all transfer data can move there instead of being generic) But this removes the bulk of the remaining contact-related code. We'll keep around the XML request objects, since it's still nice to route them to the appropriate (exception-throwing but logging) flow class.
gbrodman
force-pushed
the
removeContacts
branch
from
c40ef13 to
6a3ea19
Compare
weiminyu
approved these changes
Feb 20, 2026
Collaborator
weiminyu
left a comment
weiminyu
left a comment
There was a problem hiding this comment.
@weiminyu reviewed 33 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on gbrodman).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This doesn't remove everything -- there are still other contact-related objects that we'll need to remove (e.g.
ContactPendingActionNotificationResponse) and simplifications we'll need to make (e.g. only domains can be transferred now, so all transfer data can move there instead of being generic)
But this removes the bulk of the remaining contact-related code. We'll keep around the XML request objects, since it's still nice to route them to the appropriate (exception-throwing but logging) flow class.
This change is