Remove the concept of a TransferData abstract class#2966
Merged
gbrodman merged 1 commit intogoogle:masterfrom Feb 23, 2026
Merged
Remove the concept of a TransferData abstract class#2966gbrodman merged 1 commit intogoogle:masterfrom
gbrodman merged 1 commit intogoogle:masterfrom
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
core/src/main/java/google/registry/model/domain/DomainBase.java
Dismissed
Show dismissed
Hide dismissed
core/src/main/java/google/registry/model/transfer/DomainTransferData.java
Dismissed
Show dismissed
Hide dismissed
The only type of thing that can be transferred now is a domain, so there's no point in having this abstract class / redirection. This does not include deletion of the contact-response-related XML classes; that can come next.
gbrodman
force-pushed
the
transferData
branch
from
1c190a3 to
9366093
Compare
weiminyu
approved these changes
Feb 23, 2026
Collaborator
weiminyu
left a comment
weiminyu
left a comment
There was a problem hiding this comment.
@weiminyu partially reviewed 19 files and all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on gbrodman).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The only type of thing that can be transferred now is a domain, so there's no point in having this abstract class / redirection.
This does not include deletion of the contact-response-related XML classes; that can come next.
This change is