Avoid Abseil hash cache crashes under ASan#634
Open
VoltVoks wants to merge 1 commit into
Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #589.
Fixes #596.
This change avoids crashes in internal cache paths that use Abseil flat hash containers after extremely small memory budgets or failed cache setup leave those containers in an unsafe empty/zero-capacity state under ASan.
The two issue reproducers hit the same failure family:
max_mem.This patch replaces the affected internal Abseil flat hash caches with standard unordered containers in the compiler and DFA cache paths, and keeps
DFA::ClearCache()from iterating empty state caches. I also added regression coverage toRE2.NoCrashfor both the crafted UTF-8 char-class pattern and the tiny-memory DFA teardown path.Local verification:
Results: