Skip to content

Fix bignum.cc build failure on GCC 8 (x86_64) #569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
akhanzode wants to merge 1 commit into from
+3 −3
Closed

Fix bignum.cc build failure on GCC 8 (x86_64) #569

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/s2/util/math/exactfloat/bignum.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

#include "s2/util/math/exactfloat/bignum.h"

#ifdef __x86_64__
#if defined(__x86_64__) && (defined(__clang__) || (defined(__GNUC__) && __GNUC__ >= 9) || defined(__ADX__))
#include <immintrin.h>
#endif

Expand Down Expand Up @@ -292,7 +292,7 @@ inline Bigit AddBigit(Bigit a, Bigit b, Bigit* absl_nonnull carry) {
// Godbolt link for comparison:
// https://godbolt.org/z/cGnnfMbMn (no intrinsics)
// https://godbolt.org/z/jnM1Y3Tjs (intrinsics)
#ifdef __x86_64__
#if defined(__x86_64__) && (defined(__clang__) || (defined(__GNUC__) && __GNUC__ >= 9) || defined(__ADX__))
static_assert(sizeof(Bigit) == sizeof(unsigned long long));
Bigit out;
*carry =
Expand All @@ -311,7 +311,7 @@ inline Bigit AddBigit(Bigit a, Bigit b, Bigit* absl_nonnull carry) {
inline Bigit SubBigit(Bigit a, Bigit b, Bigit* absl_nonnull borrow) {
ABSL_DCHECK_LE(*borrow, Bigit(1));
// See notes in AddBigit on why using an intrinsic is the right choice here.
#ifdef __x86_64__
#if defined(__x86_64__) && (defined(__clang__) || (defined(__GNUC__) && __GNUC__ >= 9) || defined(__ADX__))
Bigit out;
*borrow = _subborrow_u64(static_cast<char>(*borrow), a, b,
reinterpret_cast<unsigned long long*>(&out));
Expand Down