Skip to content

Raise TextFSMTemplateError for a Value line with no regex #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arpitjain099 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Raise TextFSMTemplateError for a Value line with no regex #141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions tests/textfsm_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,12 @@ def testFSMValue(self):
textfsm.TextFSMTemplateError, v.Parse, r'Value beer (boo)hoo\)'
)

# A missing regex is a template error, not an IndexError.
v = textfsm.TextFSMValue(options_class=textfsm.TextFSMOptions)
self.assertRaises(
textfsm.TextFSMTemplateError, v.Parse, 'Value Required beer'
)

# Unbalanced parenthesis can exist if within square "[]" braces.
v = textfsm.TextFSMValue(options_class=textfsm.TextFSMOptions)
v.Parse('Value beer (boo[(]hoo)')
Expand Down Expand Up @@ -265,6 +271,9 @@ def testParseFSMVariables(self):
buf = 'Value filldown,Required Wine ((c|C)laret)'
f = io.StringIO(buf)
self.assertRaises(textfsm.TextFSMTemplateError, t._ParseFSMVariables, f)
buf = 'Value Required Beer'
f = io.StringIO(buf)
self.assertRaises(textfsm.TextFSMTemplateError, t._ParseFSMVariables, f)

# Values that look bad but are OK.
buf = (
Expand Down
7 changes: 6 additions & 1 deletion textfsm/parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,12 @@ def Parse(self, value):
"Invalid Value name '%s' or name too long." % self.name
)

if self.regex[0] != '(' or self.regex[-1] != ')' or self.regex[-2] == '\\':
if (
not self.regex
or self.regex[0] != '('
or self.regex[-1] != ')'
or self.regex[-2] == '\\'
):
raise TextFSMTemplateError(
"Value '%s' must be contained within a '()' pair." % self.regex
)
Expand Down