Skip to content

rename cmd line flag enable_psp_tcp to peregrine_enable_psp_tcp #1504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
copybara-service wants to merge 1 commit into from
Closed

rename cmd line flag enable_psp_tcp to peregrine_enable_psp_tcp #1504

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tpu_sync/transport/block_transport_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -484,7 +484,7 @@ class BlockTransportTest : public ::testing::TestWithParam<bool> {
if (GetParam() && !IsPspSupported()) {
GTEST_SKIP() << "PSP-TCP is unimplemented.";
}
absl::SetFlag(&FLAGS_enable_psp_tcp, GetParam());
absl::SetFlag(&FLAGS_peregrine_enable_psp_tcp, GetParam());
}

void TearDown() override {
Expand Down
2 changes: 1 addition & 1 deletion tpu_sync/transport/lib/psp/peregrine_control_service_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ ReqMsg MakeValidReq() {
}

TEST(PeregrineControlServiceTest, ProcessUnary) {
absl::SetFlag(&FLAGS_enable_psp_tcp, true);
absl::SetFlag(&FLAGS_peregrine_enable_psp_tcp, true);
FakeRawDelegate raw_delegate;
RawBufferTransport transport(&raw_delegate, /*local_port=*/0);
PeregrineControlServiceImpl service(&transport);
Expand Down
2 changes: 1 addition & 1 deletion tpu_sync/transport/lib/raw_buffer_transport.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,7 @@ RawBufferTransport::RawBufferTransport(
bound_ip_(local_ips.empty() ? "127.0.0.1" : local_ips[0]),
local_ips_(local_ips),
local_port_(local_port),
require_psp_tcp_(absl::GetFlag(FLAGS_enable_psp_tcp)),
require_psp_tcp_(absl::GetFlag(FLAGS_peregrine_enable_psp_tcp)),
pin_recv_threads_to_nic_numa_(PinRecvThreadsToNicNumaEnabled()),
server_fd_(-1),
stopping_(false),
Expand Down
2 changes: 1 addition & 1 deletion tpu_sync/transport/lib/raw_buffer_transport_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,7 @@ class RawBufferTransportTest : public ::testing::TestWithParam<bool> {
if (GetParam() && !IsPspSupported()) {
GTEST_SKIP() << "PSP-TCP is unimplemented.";
}
absl::SetFlag(&FLAGS_enable_psp_tcp, GetParam());
absl::SetFlag(&FLAGS_peregrine_enable_psp_tcp, GetParam());
}

void TearDown() override {
Expand Down
Loading