Skip to content

Fix agentic cli dataloading#1416

Open
wang2yn84 wants to merge 1 commit intomainfrom
lance-gsm8k
Open

Fix agentic cli dataloading#1416
wang2yn84 wants to merge 1 commit intomainfrom
lance-gsm8k

Conversation

@wang2yn84
Copy link
Copy Markdown
Collaborator

@wang2yn84 wang2yn84 commented Apr 17, 2026

This PR fixes the broken cli data loading for gsm8k; Refactor the standard and agentic grpo to a single function, deduped a lot of boilerplate code.

Reference

Colab Notebook

Checklist

  • I have added all the necessary unit tests for my change.
  • I have verified that my change does not break existing code and all unit tests pass.
  • I have added all appropriate doc-strings/documentation.
  • My PR is based on the latest changes of the main branch (if unsure, rebase the code).
  • I have signed the Contributor License Agreement.
  • I have followed Contribution Guidelines.

@wang2yn84 wang2yn84 changed the title Debug agentic cli with gsm8k. Fix agentic cli dataloading Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tianshub tianshub Awaiting requested review from tianshub tianshub is a code owner

@lc5211 lc5211 Awaiting requested review from lc5211 lc5211 is a code owner

@hgao327 hgao327 Awaiting requested review from hgao327 hgao327 is a code owner

@sizhit2 sizhit2 Awaiting requested review from sizhit2 sizhit2 is a code owner

@abheesht17 abheesht17 Awaiting requested review from abheesht17 abheesht17 is a code owner

@jiangyangmu jiangyangmu Awaiting requested review from jiangyangmu jiangyangmu is a code owner

@s-noghabi s-noghabi Awaiting requested review from s-noghabi s-noghabi is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@sizhit2 sizhit2

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wang2yn84 @sizhit2