fix: catch errors in responseToReadable _read callback#1454
Open
alliasgher wants to merge 1 commit intogoogle:mainfrom
Open
fix: catch errors in responseToReadable _read callback#1454alliasgher wants to merge 1 commit intogoogle:mainfrom
alliasgher wants to merge 1 commit intogoogle:mainfrom
Conversation
The async _read callback in responseToReadable did not wrap reader.read() in a try/catch. If the reader throws (network error, abort, corrupted stream), the rejection was unhandled and could crash the process. Catch the error and call rs.destroy(err) so downstream consumers can handle it gracefully through the stream's error event. Fixes google#1443 Signed-off-by: alliasgher <alliasgher123@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1443. The async _read callback in responseToReadable did not wrap reader.read() in a try/catch. If the reader throws (network error, abort, corrupted stream), the rejection was unhandled and could crash the process. Now caught and propagated via rs.destroy(err).