fix: add types to default and verify_token and Request __init__ based on comments in the source code. #1588
+24
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arithmetic1728
added
the
kokoro:run
yoshi-kokoro
removed
the
kokoro:run
Contributor
|
Could you squash your commits, and change the commit message to |
Author
|
Happy to! |
Recently, I've been using this library with mypy strict mode, which doesn't like the fact that these functions are unannotated (they're the only functions I use, and thus the only ones mypy complains about to me). I'm happy to see that this project has py.typed, so these annotations should fix the problem!
wyattscarpenter
force-pushed
the
patch-1
branch
from
50760ef to
ae25f47
Compare
wyattscarpenter
changed the title
wyattscarpenter
commented
Aug 5, 2025
| audience: str | list[str] | None = None, | ||
| certs_url: str = _GOOGLE_OAUTH2_CERTS_URL, | ||
| clock_skew_in_seconds: int = 0, | ||
| ) -> Mapping[str, Any]: |
Author
There was a problem hiding this comment.
It's actually bad to return something with Any in it, but, um, that's just what was in the comment. ¯\_(ツ)_/¯
If the reviewer happens to have a better & more-accurate idea, let him change this line accordingly.
Author
|
I'm hoping I can get this looked at in the near future. Also, it seems like (at least this time), it's the title of the PR that has to have fix: in it for conventionalcommits.org to pass, so have done so. |
wyattscarpenter
changed the title
wyattscarpenter
commented
Aug 6, 2025
chalmerlowe
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
chalmerlowe
reviewed
Dec 23, 2025
Contributor
chalmerlowe
left a comment
chalmerlowe
left a comment
There was a problem hiding this comment.
LGTM. Let's see how the tests turn out.
Kokoro and Kokoro system-3.10 were failing due to circular imports. Hopefully we can nix that using the conditional.
chalmerlowe
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
chalmerlowe
reviewed
Dec 23, 2025
chalmerlowe
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
chalmerlowe
reviewed
Dec 23, 2025
chalmerlowe
added
the
kokoro:force-run
yoshi-kokoro
removed
kokoro:force-run
chalmerlowe
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Update to deal with linting issues.
Updates to correct linting issues.
chalmerlowe
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
fixes to deal with linting and coverage errors.
chalmerlowe
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
chalmerlowe
reviewed
Dec 23, 2025
missing a dadgum space character after the comment octothorpe. 🤯
chalmerlowe
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
chalmerlowe
reviewed
Dec 23, 2025
more linting stuff related to flake8 not liking our type hinting.
chalmerlowe
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, I've been using this library with mypy strict mode, which doesn't like the fact that these functions are unannotated (they're the only functions I use, and thus the only ones mypy complains about to me). I'm happy to see that this project has py.typed, so these annotations should fix the problem!