fix: Use UV=preferred for ReAuth WebAuthn challenge #1798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since ReAuth is a second factor credential, it is not necessary to require UV here. This was discussed with ReAuth folks. Also, in practice, downstream clients disregard this because the U2F protocol doesn't expose UV enforcement.
Author
|
@cpisunyer who added this originally. Apologies if you're the wrong person to tag or if I missed some contributor task. |
gkevinzheng
previously approved these changes
Dec 17, 2025
gkevinzheng
changed the title
gkevinzheng
requested review from
gkevinzheng
and removed request for
gkevinzheng
gkevinzheng
dismissed
their stale review
Requesting an issue be filed for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since ReAuth is a second factor credential, it is not necessary to require UV here. This was discussed with ReAuth folks.
Also, in practice, downstream clients disregard this because the U2F protocol doesn't expose UV enforcement.