chore: rename _refresh_token to _perform_refresh_token

[daniel-sanche]

A recent change added an internal _refresh_token method to some credentials files.

Parts of the codebase were already using _refresh_token as an internal variable, holding a token value

This causes some inconsistencies in the codebase, where it's not always clear if _refresh_token is referring to an action or an object

It was also causing complications in internal code that depended on _refresh_token objects

This PR renames the methods to _perform_refresh_token, to avoid the duplicate naming

[gemini-code-assist]

Summary of Changes

Hello @daniel-sanche, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical naming conflict within the codebase by systematically renaming an internal method and a related variable. The _refresh_token method, responsible for performing the token refresh operation, has been renamed to _perform_refresh_token to clearly distinguish it from instances where _refresh_token referred to the token value itself. This refactoring significantly enhances code clarity, reduces ambiguity, and prevents potential issues stemming from overloaded naming conventions, leading to a more maintainable and understandable codebase.

Highlights

• Method Renaming: The internal _refresh_token method has been consistently renamed to _perform_refresh_token across multiple credentials classes. This change clarifies its role as an action rather than a data attribute.
• Variable Renaming: In google/auth/external_account_authorized_user.py, the internal attribute _refresh_token_val has been renamed to _refresh_token. This aligns its naming with the new convention and removes redundancy.
• Improved Code Clarity: These renames resolve a naming conflict where _refresh_token was ambiguously used for both a method (an action) and a variable (a token value). This refactoring enhances readability and prevents potential complications arising from overloaded names.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request is a refactoring to rename the internal _refresh_token method to _perform_refresh_token across the codebase. This change aims to resolve ambiguity where _refresh_token was used as both a method name and a variable name for a token value. The changes are generally correct and consistently applied. However, I found a critical typo in an error message that should be corrected.

[daniel-sanche]

This appears to be a bug in the previous code. I think this was supposed to be self._refresh_token_val.

This PR should fix any issue here though

[chalmerlowe]

LGTM