ci: use sccache v0.10.0 with C++20#16183
Merged
Merged
Conversation
|
|
||
| WORKDIR /var/tmp/sccache | ||
| RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/v0.15.0/sccache-v0.15.0-x86_64-unknown-linux-musl.tar.gz | \ | ||
| RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/v0.10.0/sccache-v0.10.0-x86_64-unknown-linux-musl.tar.gz | \ |
There was a problem hiding this comment.
To improve maintainability and avoid duplication, use an ARG to define the sccache version string. This aligns with our practice of defining version strings in Dockerfiles using ARG so they can be easily managed and updated.
ARG SCCACHE_VERSION=0.10.0
RUN curl -fsSL https://github.com/mozilla/sccache/releases/download/v${SCCACHE_VERSION}/sccache-v${SCCACHE_VERSION}-x86_64-unknown-linux-musl.tar.gz | \
References
- In Dockerfiles, use ARG to define version strings that are duplicated across multiple files to improve maintainability.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16183 +/- ##
==========================================
- Coverage 92.23% 92.22% -0.01%
==========================================
Files 2265 2265
Lines 209832 209832
==========================================
- Hits 193529 193527 -2
- Misses 16303 16305 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
alvarowolfx
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After upgrading to sccache v0.15.0, the cxx-20 build time tripled. I don't have a good explanation for why this occurred, but the increased time began on the next commit after upgrading to v0.15.0 from v0.10.0. We will continue to monitor the build time after this PR is merged to determine if reverting the sccache version helped.