fix(bigtable): fix build when OTel metrics disabled - #16519
Merged
colinmoy merged 1 commit intoOct 1, 2026
Merged
Conversation
Define StubSelectionParams and the no-op OperationContext::StubSelection when GOOGLE_CLOUD_CPP_BIGTABLE_WITH_OTEL_METRICS is not defined.
There was a problem hiding this comment.
Code Review
This pull request refactors the metrics header to expose StubSelectionParams unconditionally and adds a default no-op implementation of OperationContext::StubSelection. To prevent duplicate definition errors at link time when OpenTelemetry metrics are enabled, the no-op implementation of StubSelection should be wrapped in a conditional compilation block.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16519 +/- ##
==========================================
- Coverage 92.38% 92.36% -0.02%
==========================================
Files 2262 2262
Lines 217100 217100
==========================================
- Hits 200557 200525 -32
- Misses 16543 16575 +32 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
scotthart
approved these changes
Oct 1, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Define StubSelectionParams and the no-op OperationContext::StubSelection when GOOGLE_CLOUD_CPP_BIGTABLE_WITH_OTEL_METRICS is not defined.