chore: update templates to use gapic-libraries-bom#12872
Open
suztomo wants to merge 1 commit intogoogleapis:mainfrom
Open
chore: update templates to use gapic-libraries-bom#12872suztomo wants to merge 1 commit intogoogleapis:mainfrom
suztomo wants to merge 1 commit intogoogleapis:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the GitHub Actions reference logic in update_generation_config.sh to utilize gapic-libraries-bom and modifies the renovate_config_check.yaml workflow to trigger on its own changes while streamlining the validation process with npx. A critical issue was identified regarding the pinned version of the renovate package, which appears to be a typo and would cause the CI job to fail.
suztomo
force-pushed
the
update-templates-gapic-bom
branch
from
0954f34 to
a61aebf
Compare
suztomo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the templates in
sdk-platform-java/hermetic_build/library_generation/owlbot/templates/java_library/to usegapic-libraries-bomand thev{version}tag format for action versioning.The Git tag for shared dependencies BOM version is created by an automation (GitHub Actions) automatically. While it would work just fine, chaining automated events will make future troubleshooting difficult. So let's rely on the original tag of the google-cloud-java repository, which matches gapic-libraries-bom version.