Skip to content

ci: add conditional-required-check for hermetic-build-scripts ci#12884

Merged
chingor13 merged 10 commits intomainfrom
conditional-matrix-required
Apr 22, 2026
Merged

ci: add conditional-required-check for hermetic-build-scripts ci#12884
chingor13 merged 10 commits intomainfrom
conditional-matrix-required

Conversation

@chingor13
Copy link
Copy Markdown
Contributor

@chingor13 chingor13 commented Apr 21, 2026 •
edited
Loading

This adds a new final job to GitHub actions workflows that conditionally skip tests using jobs.if. The new required job looks to see if any of the jobs within that workflow marked as needs have failed. If any have failed, then this test is marked as failed. Otherwise, it is marked as succeeded. We can make this new conditional-required-check a required check for merging PRs.

Towards #12702

@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist Bot commented Apr 21, 2026

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@chingor13 chingor13 marked this pull request as ready for review April 22, 2026 04:13
@chingor13 chingor13 requested a review from a team as a code owner April 22, 2026 04:13
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 22, 2026

Quality Gate Passed Quality Gate passed for 'gapic-generator-java-root'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 22, 2026

Quality Gate Passed Quality Gate passed for 'gapic-generator-java-root'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@chingor13 chingor13 force-pushed the conditional-matrix-required branch from 514b0e7 to 4d875ff Compare April 22, 2026 04:59
suztomo
suztomo approved these changes Apr 22, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@suztomo suztomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see.

I didn't find "final" check in this pull request.

@suztomo
Copy link
Copy Markdown
Member

suztomo commented Apr 22, 2026

I didn't find "final" check in this pull request.

Found conditional-requred-check:

image

@chingor13
Copy link
Copy Markdown
Contributor Author

chingor13 commented Apr 22, 2026

conditional-requred-check

Yeah, the name field for a job determines the name of the check

@chingor13 chingor13 merged commit 4860366 into main Apr 22, 2026
241 of 251 checks passed
@chingor13 chingor13 deleted the conditional-matrix-required branch April 22, 2026 15:32
blakeli0
blakeli0 reviewed Apr 22, 2026
View reviewed changes
Comment thread .github/workflows/ci.yaml
# - run: java -version
# - run: .kokoro/dependencies.sh
# clirr:
# runs-on: ubuntu-latest
Copy link
Copy Markdown
Contributor

@blakeli0 blakeli0 Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see clirr check enabled in this repo, can we reenable it? We used to have it in sdk-platform-java.

Copy link
Copy Markdown
Contributor Author

@chingor13 chingor13 Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack: tracking in #12893

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blakeli0 blakeli0 blakeli0 left review comments

@suztomo suztomo suztomo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chingor13 @suztomo @blakeli0