Skip to content

chore(gax): Update resize delta's getter to be package-private#12886

Merged
lqiu96 merged 3 commits intomainfrom
channelpool-resize-delta-getter-visibility
Apr 22, 2026
Merged

chore(gax): Update resize delta's getter to be package-private#12886
lqiu96 merged 3 commits intomainfrom
channelpool-resize-delta-getter-visibility

Conversation

@lqiu96
Copy link
Copy Markdown
Member

@lqiu96 lqiu96 commented Apr 21, 2026

No description provided.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies the visibility of the getMaxResizeDelta() method in ChannelPoolSettings.java from public to package-private. A review comment correctly identifies this as a breaking change for external consumers of the API and suggests deprecating the method instead to allow for a smoother migration path.

@lqiu96 lqiu96 requested a review from jinseopkim0 April 21, 2026 22:05
@lqiu96 lqiu96 marked this pull request as ready for review April 21, 2026 22:05
@lqiu96 lqiu96 requested a review from a team as a code owner April 21, 2026 22:05
@sonarqubecloud
Copy link
Copy Markdown

@sonarqubecloud
Copy link
Copy Markdown

@lqiu96 lqiu96 merged commit 67fa52f into main Apr 22, 2026
152 of 158 checks passed
@lqiu96 lqiu96 deleted the channelpool-resize-delta-getter-visibility branch April 22, 2026 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants