feat(jdbc): extend OpenTelemetry instrumentation for metadata and pagination#12918
feat(jdbc): extend OpenTelemetry instrumentation for metadata and pagination#12918keshavdandeva wants to merge 5 commits intojdbc/feature-branch-otelfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request integrates OpenTelemetry tracing into the BigQuery JDBC driver, focusing on ResultSet iteration and DatabaseMetaData operations. Key changes include capturing span contexts during result set initialization and propagating them during next() calls, as well as adding tracing to metadata methods like getTables, getColumns, and getSchemas. Review feedback identifies significant performance overhead from wrapping high-frequency next() methods in telemetry scopes and points out that spans for asynchronous metadata operations end prematurely, leading to inaccurate duration metrics and fragmented traces.
…er the blocking operation `buffer.take()`
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request integrates OpenTelemetry tracing across the BigQuery JDBC driver, specifically targeting metadata operations and result set processing. Key changes include wrapping blocking operations in appropriate tracing scopes, propagating span contexts to background threads, and standardizing tracer acquisition via a new utility method. Feedback focuses on refining the tracing implementation, such as correctly handling background span parents to avoid timeline anomalies, ensuring span statuses are updated on errors, and replacing redundant null checks on SpanContext with validity checks.
b/491245568
Key Changes
Core Instrumentation Logic
BigQueryDatabaseMetaData.java(getCatalogs,getSchemas,getTables,getColumns) to capture underlying API calls.fetchNextPagesinBigQueryStatement.javaand linked background pagination spans back to it, avoiding timeline anomalies.SpanContextinBigQueryBaseResultSet.javaat creation time and made it current duringnext()inBigQueryJsonResultSet.javaandBigQueryArrowResultSet.javato survive thread hops.getSafeTracertoBigQueryJdbcOpenTelemetry.javaas a static utility to ensure consistent fallback behavior across the driver.populateArrowBufferedQueueinBigQueryStatement.javato its own private methodprocessArrowStreamto improve readability and maintainability.