feat(gax): add ResumableUploadCallable creation to Callables and HttpJsonCallableFactory - #14242
Draft
whowes wants to merge 1 commit into
Draft
feat(gax): add ResumableUploadCallable creation to Callables and HttpJsonCallableFactory#14242whowes wants to merge 1 commit into
whowes wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
whowes
force-pushed
the
whowes/resumable-upload-factory
branch
2 times, most recently
from
September 2, 2026 17:30
aef944f to
8cca7df
Compare
whowes
force-pushed
the
whowes/resumable-upload-factory
branch
from
September 2, 2026 19:01
8cca7df to
13ed5aa
Compare
whowes
force-pushed
the
whowes/resumable-upload-factory
branch
from
September 2, 2026 19:11
13ed5aa to
cb17291
Compare
whowes
force-pushed
the
whowes/resumable-upload-factory
branch
2 times, most recently
from
September 2, 2026 22:07
3c30fa0 to
f88f691
Compare
whowes
force-pushed
the
whowes/resumable-upload-factory
branch
from
September 2, 2026 22:32
f88f691 to
c36a2ad
Compare
Contributor
Author
|
/gemini review |
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for resumable uploads in the HTTP/JSON transport layer by adding the createResumableUploadCallable factory method to HttpJsonCallableFactory and the resumableUpload utility method to Callables. Corresponding unit tests have also been added to verify their behavior. There are no review comments, so I have no feedback to provide.
whowes
force-pushed
the
whowes/resumable-upload-factory
branch
from
September 3, 2026 05:29
c36a2ad to
00173b2
Compare
whowes
force-pushed
the
whowes/resumable-upload-factory
branch
from
September 4, 2026 02:44
00173b2 to
34f02d0
Compare
whowes
force-pushed
the
whowes/resumable-upload-factory
branch
from
September 4, 2026 03:01
34f02d0 to
83aee5d
Compare
whowes
force-pushed
the
whowes/resumable-upload-factory
branch
2 times, most recently
from
September 4, 2026 22:35
3dbcc23 to
61e6adb
Compare
whowes
force-pushed
the
whowes/resumable-upload-factory
branch
from
September 4, 2026 23:35
61e6adb to
73a0620
Compare
…JsonCallableFactory
whowes
force-pushed
the
whowes/resumable-upload-factory
branch
from
September 5, 2026 00:51
73a0620 to
c46f507
Compare
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change wires up the minimal Callable implementation from #14241 into the relevant existing factory classes.