Skip to content

feat(gax): add ApiCallContext and request-level settings overloads to ResumableUploadCallable - #14251

Draft
whowes wants to merge 1 commit into
whowes/resumable-upload-factoryfrom
whowes/resumable-upload-call-context
Draft

feat(gax): add ApiCallContext and request-level settings overloads to ResumableUploadCallable#14251
whowes wants to merge 1 commit into
whowes/resumable-upload-factoryfrom
whowes/resumable-upload-call-context

Conversation

@whowes

@whowes whowes commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

This is needed to meet the resumable upload requirement to allow custom headers and other settings to be applied on a per-call basis.

gemini-code-assist[bot]

This comment was marked as outdated.

@whowes
whowes force-pushed the whowes/resumable-upload-call-context branch 2 times, most recently from fc4a138 to 3a29329 Compare September 4, 2026 03:01
@whowes
whowes force-pushed the whowes/resumable-upload-call-context branch 5 times, most recently from 61f6c53 to a55db92 Compare September 4, 2026 22:09
@whowes
whowes force-pushed the whowes/resumable-upload-call-context branch from a55db92 to 26f88bb Compare September 4, 2026 22:35
@whowes
whowes force-pushed the whowes/resumable-upload-call-context branch from 26f88bb to 38e3b32 Compare September 4, 2026 23:35
… ResumableUploadCallable

Add 2-, 3-, and 4-argument overloads to ResumableUploadCallable for
futureCall and resumeCall, supporting:
1. Default context and settings (used by generated ServiceClient convenience methods).
2. Per-request ApiCallContext overrides for transport metadata (extra headers, credentials).
3. Per-request ResumableUploadCallSettings overrides for state-machine knobs per go/sdk:java-scotty-design.
4. Full method accepting both call context and settings overrides.

ResumableUploadCallableImpl performs a 3-tier precedence merge on settings
and merges ApiCallContext.
@whowes
whowes force-pushed the whowes/resumable-upload-call-context branch from 38e3b32 to b599050 Compare September 5, 2026 00:51
@sonarqubecloud

sonarqubecloud Bot commented Sep 5, 2026

Copy link
Copy Markdown

@sonarqubecloud

sonarqubecloud Bot commented Sep 5, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed for 'gapic-generator-java-root'

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant