Skip to content

test(spanner): use nam6 instance config for CreateInstancePartitionSampleIT - #14261

Merged
sakthivelmanii merged 1 commit into
mainfrom
fix-create-instance-partition-sample-it
Sep 4, 2026
Merged

test(spanner): use nam6 instance config for CreateInstancePartitionSampleIT#14261
sakthivelmanii merged 1 commit into
mainfrom
fix-create-instance-partition-sample-it

Conversation

@sakthivelmanii

Copy link
Copy Markdown
Contributor

CreateInstancePartitionSample creates an instance partition with config 'nam3'. Creating instance partitions on single-region instances ('regional-us-central1') fails with:
FAILED_PRECONDITION: Cannot create an instance partition in a single region instance.

Additionally, Cloud Spanner prohibits an instance partition from sharing the exact base config of the parent instance (DuplicatedBaseInstancePartitionConfigs).

Update CreateInstancePartitionSampleIT to create the parent instance in 'nam6' with display name "Partition test instance". This satisfies the multi-region requirement while avoiding a base config collision with 'nam3'.

…mpleIT

CreateInstancePartitionSample creates an instance partition with config 'nam3'.
Creating instance partitions on single-region instances ('regional-us-central1')
fails with:
  FAILED_PRECONDITION: Cannot create an instance partition in a single region instance.

Additionally, Cloud Spanner prohibits an instance partition from sharing
the exact base config of the parent instance (DuplicatedBaseInstancePartitionConfigs).

Update CreateInstancePartitionSampleIT to create the parent instance in 'nam6'
with display name "Partition test instance". This satisfies the multi-region
requirement while avoiding a base config collision with 'nam3'.
@sakthivelmanii
sakthivelmanii requested review from a team as code owners September 4, 2026 06:28

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the CreateInstancePartitionSampleIT.java test file by changing the display name of the test instance to 'Partition test instance' and updating the instance configuration ID from 'regional-us-central1' to 'nam6'. There are no review comments, and I have no feedback to provide.

@sakthivelmanii
sakthivelmanii enabled auto-merge (squash) September 4, 2026 06:28
@sakthivelmanii
sakthivelmanii merged commit a1bcfcb into main Sep 4, 2026
204 checks passed
@sakthivelmanii
sakthivelmanii deleted the fix-create-instance-partition-sample-it branch September 4, 2026 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants