Skip to content

feat(google/cloud/agentregistry/v1): onboard a new library#8673

Merged
suztomo merged 3 commits into
googleapis:mainfrom
suztomo:chore-onboard-library-2026-06-17-google/cloud/agentregistry/v1
Jun 18, 2026
Merged

feat(google/cloud/agentregistry/v1): onboard a new library#8673
suztomo merged 3 commits into
googleapis:mainfrom
suztomo:chore-onboard-library-2026-06-17-google/cloud/agentregistry/v1

Conversation

@suztomo

@suztomo suztomo commented Jun 17, 2026

Copy link
Copy Markdown
Member

b/524670267

V=v0.20.0
API_PATH=google/cloud/agentregistry/v1
go run github.com/googleapis/librarian/cmd/librarian@${V} add "${API_PATH}"
go run github.com/googleapis/librarian/cmd/librarian@${V} generate google-cloud-agentregistry

This includes README.md.

I had to make additional commit to add the "long" in devDependencies in package.json (googleapis/librarian#6501).

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request registers and adds a new Node.js client library package, @google-cloud/agentregistry, which includes its Protocol Buffer definitions, auto-generated client code, configuration files, samples, and system tests. I have no feedback to provide as there are no review comments to evaluate.

@suztomo

suztomo commented Jun 18, 2026

Copy link
Copy Markdown
Member Author

It failed in Node 24 unit test:

> @google-cloud/agentregistry@0.1.0 compile
> tsc -p . && cp -r protos build/ && minifyProtoJson

protos/protos.d.ts:16:23 - error TS2307: Cannot find module 'long' or its corresponding type declarations.

16 import Long = require("long");
                         ~~~~~~


Found 1 error in protos/protos.d.ts:16

@suztomo suztomo marked this pull request as ready for review June 18, 2026 18:19
@suztomo suztomo requested a review from a team as a code owner June 18, 2026 18:19
@suztomo suztomo merged commit b17c653 into googleapis:main Jun 18, 2026
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants